From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] ethdev: modifiy vlan_offload_set_t to return
 int
Date: Thu, 24 Aug 2017 16:37:08 -0700
Message-ID: <20170824163708.2931e83b@xeon-e3>
References: <20170824231851.21829-1-dharton@cisco.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: thomas@monjalon.net, ferruh.yigit@intel.com, stephen.hurd@broadcom.com,
 ajit.khaparde@broadcom.com, johndale@cisco.com, wenzhuo.lu@intel.com,
 konstantin.ananyev@intel.com, jingjing.wu@intel.com, beilei.xing@intel.com,
 jing.d.chen@intel.com, adrien.mazarguil@6wind.com,
 nelio.laranjeiro@6wind.com, alejandro.lucero@netronome.com,
 hemant.agrawal@nxp.com, rasesh.mody@cavium.com, harish.patil@cavium.com,
 skhare@vmware.com, yliu@fridaylinux.org, maxime.coquelin@redhat.com,
 allain.legacy@windriver.com, dev@dpdk.org
To: David Harton <dharton@cisco.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg0-f43.google.com (mail-pg0-f43.google.com [74.125.83.43])
 by dpdk.org (Postfix) with ESMTP id C1E9C7CEE
 for <dev@dpdk.org>; Fri, 25 Aug 2017 01:37:16 +0200 (CEST)
Received: by mail-pg0-f43.google.com with SMTP id a7so4639235pgn.1
 for <dev@dpdk.org>; Thu, 24 Aug 2017 16:37:16 -0700 (PDT)
In-Reply-To: <20170824231851.21829-1-dharton@cisco.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 24 Aug 2017 19:18:51 -0400
David Harton <dharton@cisco.com> wrote:

> @@ -2031,7 +2031,7 @@ struct avp_queue {
>  	mask = (ETH_VLAN_STRIP_MASK |
>  		ETH_VLAN_FILTER_MASK |
>  		ETH_VLAN_EXTEND_MASK);
> -	avp_vlan_offload_set(eth_dev, mask);
> +	(void)avp_vlan_offload_set(eth_dev, mask);

This is a BSDism. You don't need the void cast.