From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Subject: Re: [PATCH] app/testpmd: app/testpmd: add device removal
	command
Date: Fri, 25 Aug 2017 09:53:31 +0200
Message-ID: <20170825075331.GB8124@bidouze.vm.6wind.com>
References: <1503499024-12480-1-git-send-email-rasland@mellanox.com>
 <20170823150909.GA8124@bidouze.vm.6wind.com>
 <2302304.eNG2ySBljJ@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: Raslan Darawsheh <rasland@mellanox.com>, jingjing.wu@intel.com,
 dev@dpdk.org, salehals@mellanox.com
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f178.google.com (mail-wr0-f178.google.com
 [209.85.128.178]) by dpdk.org (Postfix) with ESMTP id DE9647D05
 for <dev@dpdk.org>; Fri, 25 Aug 2017 09:53:41 +0200 (CEST)
Received: by mail-wr0-f178.google.com with SMTP id z91so4930445wrc.1
 for <dev@dpdk.org>; Fri, 25 Aug 2017 00:53:41 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <2302304.eNG2ySBljJ@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Aug 23, 2017 at 06:18:34PM +0200, Thomas Monjalon wrote:
> 23/08/2017 17:09, Gaëtan Rivet:
> > Hello Raslan,
> > 
> > On Wed, Aug 23, 2017 at 05:37:04PM +0300, Raslan Darawsheh wrote:
> > > Added hotplug in testpmd, to be able to test hotplug function
> > > in the PMD's.
> > > 
> > > Signed-off-by: Raslan Darawsheh <rasland@mellanox.com>
> [...]
> > > --- a/app/test-pmd/cmdline.c
> > > +++ b/app/test-pmd/cmdline.c
> > > @@ -716,6 +716,9 @@ static void cmd_help_long_parsed(void *parsed_result,
> > >  			"port config (port_id|all) l2-tunnel E-tag"
> > >  			" (enable|disable)\n"
> > >  			"    Enable/disable the E-tag support.\n\n"
> > > +
> > > +			" device remove (device)\n"
> > > +			"    Remove a device"
> > 
> > I think it should still be a part of the "port" command set (port
> > attach|detach|stop|close, etc).
> 
> I tend to disagree.
> As far as I know, we use port for ethdev or cryptodev.
> Here we want to deal with EAL rte_device.
> 

I see, that makes sense.
I will redo the review with that in mind.

> > This would probably be easier to understand for users.
> 
> [...]
> > Continuing on using the port ...
> > format, then the port_id should allow to remove it instead of the device
> > identifier.
> > Using the device identifier will complexify your implementation.
> [...]
> > 	eth_dev = &rte_eth_devices[port_id];
> > 	bus = rte_bus_find_by_device(eth_dev->device);
> 
> Note that we are going to remove eth_dev->device which implies eth_dev
> but maybe also more device interfaces for the same HW.
> That's why I think we need to distinguish port and device somehow.

-- 
Gaëtan Rivet
6WIND