From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] ethdev: modifiy vlan_offload_set_t to return
 int
Date: Fri, 25 Aug 2017 09:20:36 +0100
Message-ID: <20170825082036.GA9968@bricha3-MOBL3.ger.corp.intel.com>
References: <20170824231851.21829-1-dharton@cisco.com>
 <20170824163708.2931e83b@xeon-e3>
 <69ca37d9a8014b49bfb5b156f98eba03@XCH-RCD-016.cisco.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Stephen Hemminger <stephen@networkplumber.org>,
 "thomas@monjalon.net" <thomas@monjalon.net>,
 "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
 "stephen.hurd@broadcom.com" <stephen.hurd@broadcom.com>,
 "ajit.khaparde@broadcom.com" <ajit.khaparde@broadcom.com>,
 "John Daley (johndale)" <johndale@cisco.com>,
 "wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com>,
 "konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
 "jingjing.wu@intel.com" <jingjing.wu@intel.com>,
 "beilei.xing@intel.com" <beilei.xing@intel.com>,
 "jing.d.chen@intel.com" <jing.d.chen@intel.com>,
 "adrien.mazarguil@6wind.com" <adrien.mazarguil@6wind.com>,
 "nelio.laranjeiro@6wind.com" <nelio.laranjeiro@6wind.com>,
 "alejandro.lucero@netronome.com" <alejandro.lucero@netronome.com>,
 "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
 "rasesh.mody@cavium.com" <rasesh.mody@cavium.com>,
 "harish.patil@cavium.com" <har
To: "David Harton (dharton)" <dharton@cisco.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id B31137CFC
 for <dev@dpdk.org>; Fri, 25 Aug 2017 10:20:46 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <69ca37d9a8014b49bfb5b156f98eba03@XCH-RCD-016.cisco.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Aug 25, 2017 at 12:55:21AM +0000, David Harton (dharton) wrote:
> 
> 
> > -----Original Message-----
> > From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > Sent: Thursday, August 24, 2017 7:37 PM
> > To: David Harton (dharton) <dharton@cisco.com>
> > Cc: thomas@monjalon.net; ferruh.yigit@intel.com;
> > stephen.hurd@broadcom.com; ajit.khaparde@broadcom.com; John Daley
> > (johndale) <johndale@cisco.com>; wenzhuo.lu@intel.com;
> > konstantin.ananyev@intel.com; jingjing.wu@intel.com;
> > beilei.xing@intel.com; jing.d.chen@intel.com; adrien.mazarguil@6wind.com;
> > nelio.laranjeiro@6wind.com; alejandro.lucero@netronome.com;
> > hemant.agrawal@nxp.com; rasesh.mody@cavium.com; harish.patil@cavium.com;
> > skhare@vmware.com; yliu@fridaylinux.org; maxime.coquelin@redhat.com;
> > allain.legacy@windriver.com; dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] ethdev: modifiy vlan_offload_set_t to
> > return int
> > 
> > On Thu, 24 Aug 2017 19:18:51 -0400
> > David Harton <dharton@cisco.com> wrote:
> > 
> > > @@ -2031,7 +2031,7 @@ struct avp_queue {
> > >  	mask = (ETH_VLAN_STRIP_MASK |
> > >  		ETH_VLAN_FILTER_MASK |
> > >  		ETH_VLAN_EXTEND_MASK);
> > > -	avp_vlan_offload_set(eth_dev, mask);
> > > +	(void)avp_vlan_offload_set(eth_dev, mask);
> > 
> > This is a BSDism. You don't need the void cast.
> 
> Never know what to do...SA tools and some compilers whine if I don't.
> People complain if I do. :)
> 
> What if I check the return code and log an error? 

Sounds like a case of "doing the right thing" to me :-)