Re: using rte_flow via tespmd with Intel X552

Re: using rte_flow via tespmd with Intel X552

[TETSURO NAKAMURA]

Wei Zhao - san
(Cc'ing Wenzhuo - san)

According to the e-mail thread [1] in April,
you have a document about command format when creating flows on ixgbe NIC.

I would appreciate your uploading that document to community or
could you just share it with me via an e-mail ??

[1] http://dpdk.org/ml/archives/users/2017-April/001786.html

Thanks,

Tetsuro

# re-sending the e-mail because I failed to submit the e-mail to 
users@dpdk.org.

-- 
Tetsuro Nakamura <nakamura.tetsuro@lab.ntt.co.jp>
NTT Network Service Systems Laboratories
TEL:0422 59 6914(National)/+81 422 59 6914(International)
3-9-11, Midori-Cho Musashino-Shi, Tokyo 180-8585 Japan

Re: using rte_flow via tespmd with Intel X552

[Zhao1, Wei]

Hi, NAKAMURA

I have upload 2 documents about command format when creating flow for NIC igb and ixgbe in the email attachment.
I have decided to commit the context in the doc to doc\guides\nics\ixgbe.rst before, BUT by now it seems the content of the document is too much
To store there. So, is there any other doc more suitable in DPDK to record this. And welcome for any other suggestion. 
AND, Wenzhuo, what is your opinion for this?



> -----Original Message-----
> From: TETSURO NAKAMURA [mailto:nakamura.tetsuro@lab.ntt.co.jp]
> Sent: Wednesday, August 2, 2017 12:22 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>
> Cc: TAKADA Naoki <takada.naoki@lab.ntt.co.jp>; Satoshi NISHIYAMA
> <nishiyama.s@lab.ntt.co.jp>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> dev@dpdk.org
> Subject: Re: using rte_flow via tespmd with Intel X552
> 
> Wei Zhao - san
> (Cc'ing Wenzhuo - san)
> 
> According to the e-mail thread [1] in April, you have a document about
> command format when creating flows on ixgbe NIC.
> 
> I would appreciate your uploading that document to community or could you
> just share it with me via an e-mail ??
> 
> [1] http://dpdk.org/ml/archives/users/2017-April/001786.html
> 
> Thanks,
> 
> Tetsuro
> 
> # re-sending the e-mail because I failed to submit the e-mail to
> users@dpdk.org.
> 
> --
> Tetsuro Nakamura <nakamura.tetsuro@lab.ntt.co.jp> NTT Network Service
> Systems Laboratories
> TEL:0422 59 6914(National)/+81 422 59 6914(International) 3-9-11, Midori-Cho
> Musashino-Shi, Tokyo 180-8585 Japan
> 

Re: using rte_flow via tespmd with Intel X552

[TETSURO NAKAMURA]

Hi Zhao1, Wei - san,

I really appreciate your help !
I have no idea where to upload this,
but I'm sure it should be uploaded to somewhere public.

On 2017/08/02 16:28, Zhao1, Wei wrote:
> Hi, NAKAMURA
> 
> I have upload 2 documents about command format when creating flow for NIC igb and ixgbe in the email attachment.
> I have decided to commit the context in the doc to doc\guides\nics\ixgbe.rst before, BUT by now it seems the content of the document is too much
> To store there. So, is there any other doc more suitable in DPDK to record this. And welcome for any other suggestion.
> AND, Wenzhuo, what is your opinion for this?
> 
> 
> 
>> -----Original Message-----
>> From: TETSURO NAKAMURA [mailto:nakamura.tetsuro@lab.ntt.co.jp]
>> Sent: Wednesday, August 2, 2017 12:22 PM
>> To: Zhao1, Wei <wei.zhao1@intel.com>
>> Cc: TAKADA Naoki <takada.naoki@lab.ntt.co.jp>; Satoshi NISHIYAMA
>> <nishiyama.s@lab.ntt.co.jp>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
>> dev@dpdk.org
>> Subject: Re: using rte_flow via tespmd with Intel X552
>>
>> Wei Zhao - san
>> (Cc'ing Wenzhuo - san)
>>
>> According to the e-mail thread [1] in April, you have a document about
>> command format when creating flows on ixgbe NIC.
>>
>> I would appreciate your uploading that document to community or could you
>> just share it with me via an e-mail ??
>>
>> [1] http://dpdk.org/ml/archives/users/2017-April/001786.html
>>
>> Thanks,
>>
>> Tetsuro
>>
>> # re-sending the e-mail because I failed to submit the e-mail to
>> users@dpdk.org.
>>
>> --
>> Tetsuro Nakamura <nakamura.tetsuro@lab.ntt.co.jp> NTT Network Service
>> Systems Laboratories
>> TEL:0422 59 6914(National)/+81 422 59 6914(International) 3-9-11, Midori-Cho
>> Musashino-Shi, Tokyo 180-8585 Japan
>>
> 

-- 
Tetsuro Nakamura <nakamura.tetsuro@lab.ntt.co.jp>
NTT Network Service Systems Laboratories
TEL:0422 59 6914(National)/+81 422 59 6914(International)
3-9-11, Midori-Cho Musashino-Shi, Tokyo 180-8585 Japan

Re: using rte_flow via tespmd with Intel X552

[Zhao1, Wei]

Hi,  NAKAMURA
     

> -----Original Message-----
> From: TETSURO NAKAMURA [mailto:nakamura.tetsuro@lab.ntt.co.jp]
> Sent: Wednesday, August 2, 2017 5:02 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>
> Cc: TAKADA Naoki <takada.naoki@lab.ntt.co.jp>; Satoshi NISHIYAMA
> <nishiyama.s@lab.ntt.co.jp>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> dev@dpdk.org
> Subject: Re: using rte_flow via tespmd with Intel X552
> 
> Hi Zhao1, Wei - san,
> 
> I really appreciate your help !
> I have no idea where to upload this,
> but I'm sure it should be uploaded to somewhere public.
> 

    No problem! (●'◡'●)

> On 2017/08/02 16:28, Zhao1, Wei wrote:
> > Hi, NAKAMURA
> >
> > I have upload 2 documents about command format when creating flow for
> NIC igb and ixgbe in the email attachment.
> > I have decided to commit the context in the doc to
> > doc\guides\nics\ixgbe.rst before, BUT by now it seems the content of the
> document is too much To store there. So, is there any other doc more
> suitable in DPDK to record this. And welcome for any other suggestion.
> > AND, Wenzhuo, what is your opinion for this?
> >
> >
> >
> >> -----Original Message-----
> >> From: TETSURO NAKAMURA [mailto:nakamura.tetsuro@lab.ntt.co.jp]
> >> Sent: Wednesday, August 2, 2017 12:22 PM
> >> To: Zhao1, Wei <wei.zhao1@intel.com>
> >> Cc: TAKADA Naoki <takada.naoki@lab.ntt.co.jp>; Satoshi NISHIYAMA
> >> <nishiyama.s@lab.ntt.co.jp>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> >> dev@dpdk.org
> >> Subject: Re: using rte_flow via tespmd with Intel X552
> >>
> >> Wei Zhao - san
> >> (Cc'ing Wenzhuo - san)
> >>
> >> According to the e-mail thread [1] in April, you have a document
> >> about command format when creating flows on ixgbe NIC.
> >>
> >> I would appreciate your uploading that document to community or could
> >> you just share it with me via an e-mail ??
> >>
> >> [1] http://dpdk.org/ml/archives/users/2017-April/001786.html
> >>
> >> Thanks,
> >>
> >> Tetsuro
> >>
> >> # re-sending the e-mail because I failed to submit the e-mail to
> >> users@dpdk.org.
> >>
> >> --
> >> Tetsuro Nakamura <nakamura.tetsuro@lab.ntt.co.jp> NTT Network
> Service
> >> Systems Laboratories
> >> TEL:0422 59 6914(National)/+81 422 59 6914(International) 3-9-11,
> >> Midori-Cho Musashino-Shi, Tokyo 180-8585 Japan
> >>
> >
> 
> --
> Tetsuro Nakamura <nakamura.tetsuro@lab.ntt.co.jp> NTT Network Service
> Systems Laboratories
> TEL:0422 59 6914(National)/+81 422 59 6914(International) 3-9-11, Midori-Cho
> Musashino-Shi, Tokyo 180-8585 Japan
> 

Re: using rte_flow via tespmd with Intel X552

[Lu, Wenzhuo]

Hi,

> -----Original Message-----
> From: Zhao1, Wei
> Sent: Wednesday, August 2, 2017 3:28 AM
> To: TETSURO NAKAMURA <nakamura.tetsuro@lab.ntt.co.jp>
> Cc: TAKADA Naoki <takada.naoki@lab.ntt.co.jp>; Satoshi NISHIYAMA
> <nishiyama.s@lab.ntt.co.jp>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> dev@dpdk.org
> Subject: RE: using rte_flow via tespmd with Intel X552
> 
> Hi, NAKAMURA
> 
> I have upload 2 documents about command format when creating flow for
> NIC igb and ixgbe in the email attachment.
> I have decided to commit the context in the doc to doc\guides\nics\ixgbe.rst
> before, BUT by now it seems the content of the document is too much To
> store there. So, is there any other doc more suitable in DPDK to record this.
> And welcome for any other suggestion.
> AND, Wenzhuo, what is your opinion for this?
I also have the same feeling that it may make the ixgbe.rst too big. 
+ John and Adrien. Hi John,  Adrien, I'm think about creating a specific doc for rte flow, we can include the examples for every NIC here. Is it good? If so, where's the good place to put it? Thanks.

> 
> 
> 
> > -----Original Message-----
> > From: TETSURO NAKAMURA [mailto:nakamura.tetsuro@lab.ntt.co.jp]
> > Sent: Wednesday, August 2, 2017 12:22 PM
> > To: Zhao1, Wei <wei.zhao1@intel.com>
> > Cc: TAKADA Naoki <takada.naoki@lab.ntt.co.jp>; Satoshi NISHIYAMA
> > <nishiyama.s@lab.ntt.co.jp>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> > dev@dpdk.org
> > Subject: Re: using rte_flow via tespmd with Intel X552
> >
> > Wei Zhao - san
> > (Cc'ing Wenzhuo - san)
> >
> > According to the e-mail thread [1] in April, you have a document about
> > command format when creating flows on ixgbe NIC.
> >
> > I would appreciate your uploading that document to community or could
> > you just share it with me via an e-mail ??
> >
> > [1] http://dpdk.org/ml/archives/users/2017-April/001786.html
> >
> > Thanks,
> >
> > Tetsuro
> >
> > # re-sending the e-mail because I failed to submit the e-mail to
> > users@dpdk.org.
> >
> > --
> > Tetsuro Nakamura <nakamura.tetsuro@lab.ntt.co.jp> NTT Network Service
> > Systems Laboratories
> > TEL:0422 59 6914(National)/+81 422 59 6914(International) 3-9-11,
> > Midori-Cho Musashino-Shi, Tokyo 180-8585 Japan
> >

Re: using rte_flow via tespmd with Intel X552

[Adrien Mazarguil]

Hi Wenzhuo,

On Wed, Aug 02, 2017 at 01:00:47PM +0000, Lu, Wenzhuo wrote:
> Hi,
> 
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Wednesday, August 2, 2017 3:28 AM
> > To: TETSURO NAKAMURA <nakamura.tetsuro@lab.ntt.co.jp>
> > Cc: TAKADA Naoki <takada.naoki@lab.ntt.co.jp>; Satoshi NISHIYAMA
> > <nishiyama.s@lab.ntt.co.jp>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> > dev@dpdk.org
> > Subject: RE: using rte_flow via tespmd with Intel X552
> > 
> > Hi, NAKAMURA
> > 
> > I have upload 2 documents about command format when creating flow for
> > NIC igb and ixgbe in the email attachment.
> > I have decided to commit the context in the doc to doc\guides\nics\ixgbe.rst
> > before, BUT by now it seems the content of the document is too much To
> > store there. So, is there any other doc more suitable in DPDK to record this.
> > And welcome for any other suggestion.
> > AND, Wenzhuo, what is your opinion for this?
> I also have the same feeling that it may make the ixgbe.rst too big. 
> + John and Adrien. Hi John,  Adrien, I'm think about creating a specific doc for rte flow, we can include the examples for every NIC here. Is it good? If so, where's the good place to put it? Thanks.

Depends on the kind of examples. Code samples or testpmd flow command?
Unless you mean a document that describes individual rte_flow features
supported by each NIC?

Code samples could be added to a new "Programming flow rules" (or something)
section in doc/guide/prog_guide/rte_flow.rst.

Another section about NICs could be added in that documentation as well but
should only contain a short summary for each of them and a link to the
relevant PMD documentation in nics/$PMD.rst (or elsewhere in the DPDK
tree), if any.

If you want to describe individual rte_flow features supported by each NIC,
I think there's no other choice but to create a bunch of
doc/guides/nics/features/rte_flow/*.ini files.

> > > -----Original Message-----
> > > From: TETSURO NAKAMURA [mailto:nakamura.tetsuro@lab.ntt.co.jp]
> > > Sent: Wednesday, August 2, 2017 12:22 PM
> > > To: Zhao1, Wei <wei.zhao1@intel.com>
> > > Cc: TAKADA Naoki <takada.naoki@lab.ntt.co.jp>; Satoshi NISHIYAMA
> > > <nishiyama.s@lab.ntt.co.jp>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> > > dev@dpdk.org
> > > Subject: Re: using rte_flow via tespmd with Intel X552
> > >
> > > Wei Zhao - san
> > > (Cc'ing Wenzhuo - san)
> > >
> > > According to the e-mail thread [1] in April, you have a document about
> > > command format when creating flows on ixgbe NIC.
> > >
> > > I would appreciate your uploading that document to community or could
> > > you just share it with me via an e-mail ??
> > >
> > > [1] http://dpdk.org/ml/archives/users/2017-April/001786.html
> > >
> > > Thanks,
> > >
> > > Tetsuro
> > >
> > > # re-sending the e-mail because I failed to submit the e-mail to
> > > users@dpdk.org.
> > >
> > > --
> > > Tetsuro Nakamura <nakamura.tetsuro@lab.ntt.co.jp> NTT Network Service
> > > Systems Laboratories
> > > TEL:0422 59 6914(National)/+81 422 59 6914(International) 3-9-11,
> > > Midori-Cho Musashino-Shi, Tokyo 180-8585 Japan
> > >
> 

-- 
Adrien Mazarguil
6WIND

Re: using rte_flow via tespmd with Intel X552

[Zhao1, Wei]

Hi, Adrien

> -----Original Message-----
> From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com]
> Sent: Wednesday, August 2, 2017 9:41 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>
> Cc: Zhao1, Wei <wei.zhao1@intel.com>; TETSURO NAKAMURA
> <nakamura.tetsuro@lab.ntt.co.jp>; Mcnamara, John
> <john.mcnamara@intel.com>; TAKADA Naoki <takada.naoki@lab.ntt.co.jp>;
> Satoshi NISHIYAMA <nishiyama.s@lab.ntt.co.jp>; dev@dpdk.org
> Subject: Re: using rte_flow via tespmd with Intel X552
> 
> Hi Wenzhuo,
> 
> On Wed, Aug 02, 2017 at 01:00:47PM +0000, Lu, Wenzhuo wrote:
> > Hi,
> >
> > > -----Original Message-----
> > > From: Zhao1, Wei
> > > Sent: Wednesday, August 2, 2017 3:28 AM
> > > To: TETSURO NAKAMURA <nakamura.tetsuro@lab.ntt.co.jp>
> > > Cc: TAKADA Naoki <takada.naoki@lab.ntt.co.jp>; Satoshi NISHIYAMA
> > > <nishiyama.s@lab.ntt.co.jp>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> > > dev@dpdk.org
> > > Subject: RE: using rte_flow via tespmd with Intel X552
> > >
> > > Hi, NAKAMURA
> > >
> > > I have upload 2 documents about command format when creating flow
> > > for NIC igb and ixgbe in the email attachment.
> > > I have decided to commit the context in the doc to
> > > doc\guides\nics\ixgbe.rst before, BUT by now it seems the content of
> > > the document is too much To store there. So, is there any other doc more
> suitable in DPDK to record this.
> > > And welcome for any other suggestion.
> > > AND, Wenzhuo, what is your opinion for this?
> > I also have the same feeling that it may make the ixgbe.rst too big.
> > + John and Adrien. Hi John,  Adrien, I'm think about creating a specific doc
> for rte flow, we can include the examples for every NIC here. Is it good? If so,
> where's the good place to put it? Thanks.
> 
> Depends on the kind of examples. Code samples or testpmd flow command?
> Unless you mean a document that describes individual rte_flow features
> supported by each NIC?
> 
> Code samples could be added to a new "Programming flow rules" (or
> something) section in doc/guide/prog_guide/rte_flow.rst.
> 
> Another section about NICs could be added in that documentation as well
> but should only contain a short summary for each of them and a link to the
> relevant PMD documentation in nics/$PMD.rst (or elsewhere in the DPDK
> tree), if any.
> 
> If you want to describe individual rte_flow features supported by each NIC, I
> think there's no other choice but to create a bunch of
> doc/guides/nics/features/rte_flow/*.ini files.

Your suggestion of create a bunch under > doc/guides/nics/features/rte_flow/*.ini  to record these for every type of NIC of igb/ixgbe/i40e,
It seems very reasonable, but will DPDK community will agree to such a big change for this a specific feature?
 Maybe your suggestion of "in doc/guide/prog_guide/rte_flow.rst,  add  a short summary for each of them and a link to the
 relevant PMD documentation in nics/$PMD.rst ".
and also record to doc\guides\nics\ixgbe.rst will be the only feasible scheme?
Although it  will be too much to store.

Wenzhuo and Adrien, If none of you has no objection to this, I will implement as Adrien's first suggestion.

Thank you.
> 
> > > > -----Original Message-----
> > > > From: TETSURO NAKAMURA [mailto:nakamura.tetsuro@lab.ntt.co.jp]
> > > > Sent: Wednesday, August 2, 2017 12:22 PM
> > > > To: Zhao1, Wei <wei.zhao1@intel.com>
> > > > Cc: TAKADA Naoki <takada.naoki@lab.ntt.co.jp>; Satoshi NISHIYAMA
> > > > <nishiyama.s@lab.ntt.co.jp>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> > > > dev@dpdk.org
> > > > Subject: Re: using rte_flow via tespmd with Intel X552
> > > >
> > > > Wei Zhao - san
> > > > (Cc'ing Wenzhuo - san)
> > > >
> > > > According to the e-mail thread [1] in April, you have a document
> > > > about command format when creating flows on ixgbe NIC.
> > > >
> > > > I would appreciate your uploading that document to community or
> > > > could you just share it with me via an e-mail ??
> > > >
> > > > [1] http://dpdk.org/ml/archives/users/2017-April/001786.html
> > > >
> > > > Thanks,
> > > >
> > > > Tetsuro
> > > >
> > > > # re-sending the e-mail because I failed to submit the e-mail to
> > > > users@dpdk.org.
> > > >
> > > > --
> > > > Tetsuro Nakamura <nakamura.tetsuro@lab.ntt.co.jp> NTT Network
> > > > Service Systems Laboratories
> > > > TEL:0422 59 6914(National)/+81 422 59 6914(International) 3-9-11,
> > > > Midori-Cho Musashino-Shi, Tokyo 180-8585 Japan
> > > >
> >
> 
> --
> Adrien Mazarguil
> 6WIND

Re: using rte_flow via tespmd with Intel X552

[Ferruh Yigit]

On 8/2/2017 2:41 PM, Adrien Mazarguil wrote:
> Hi Wenzhuo,
> 
> On Wed, Aug 02, 2017 at 01:00:47PM +0000, Lu, Wenzhuo wrote:
>> Hi,
>>
>>> -----Original Message-----
>>> From: Zhao1, Wei
>>> Sent: Wednesday, August 2, 2017 3:28 AM
>>> To: TETSURO NAKAMURA <nakamura.tetsuro@lab.ntt.co.jp>
>>> Cc: TAKADA Naoki <takada.naoki@lab.ntt.co.jp>; Satoshi NISHIYAMA
>>> <nishiyama.s@lab.ntt.co.jp>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
>>> dev@dpdk.org
>>> Subject: RE: using rte_flow via tespmd with Intel X552
>>>
>>> Hi, NAKAMURA
>>>
>>> I have upload 2 documents about command format when creating flow for
>>> NIC igb and ixgbe in the email attachment.
>>> I have decided to commit the context in the doc to doc\guides\nics\ixgbe.rst
>>> before, BUT by now it seems the content of the document is too much To
>>> store there. So, is there any other doc more suitable in DPDK to record this.
>>> And welcome for any other suggestion.
>>> AND, Wenzhuo, what is your opinion for this?
>> I also have the same feeling that it may make the ixgbe.rst too big. 
>> + John and Adrien. Hi John,  Adrien, I'm think about creating a specific doc for rte flow, we can include the examples for every NIC here. Is it good? If so, where's the good place to put it? Thanks.
> 
> Depends on the kind of examples. Code samples or testpmd flow command?
> Unless you mean a document that describes individual rte_flow features
> supported by each NIC?
> 
> Code samples could be added to a new "Programming flow rules" (or something)
> section in doc/guide/prog_guide/rte_flow.rst.
> 
> Another section about NICs could be added in that documentation as well but
> should only contain a short summary for each of them and a link to the
> relevant PMD documentation in nics/$PMD.rst (or elsewhere in the DPDK
> tree), if any.
> 
> If you want to describe individual rte_flow features supported by each NIC,
> I think there's no other choice but to create a bunch of
> doc/guides/nics/features/rte_flow/*.ini files.

Indeed I was thinking doing a change in .ini files related rte flow in 17.11

rte_flow is a method to implement some filtering features, rte_flow
itself is not a device feature. And filtering features already listed in
.ini file.

So I was thinking removing rte_flow from feature table, and update
existing filter features as something like:
"Ethertype filter = L"  --> Feature exist and implemented using Legacy
method.
"Ethertype filter = Y"  --> Feature exist and implemented using rte flow

Does it make sense?

> 
>>>> -----Original Message-----
>>>> From: TETSURO NAKAMURA [mailto:nakamura.tetsuro@lab.ntt.co.jp]
>>>> Sent: Wednesday, August 2, 2017 12:22 PM
>>>> To: Zhao1, Wei <wei.zhao1@intel.com>
>>>> Cc: TAKADA Naoki <takada.naoki@lab.ntt.co.jp>; Satoshi NISHIYAMA
>>>> <nishiyama.s@lab.ntt.co.jp>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
>>>> dev@dpdk.org
>>>> Subject: Re: using rte_flow via tespmd with Intel X552
>>>>
>>>> Wei Zhao - san
>>>> (Cc'ing Wenzhuo - san)
>>>>
>>>> According to the e-mail thread [1] in April, you have a document about
>>>> command format when creating flows on ixgbe NIC.
>>>>
>>>> I would appreciate your uploading that document to community or could
>>>> you just share it with me via an e-mail ??
>>>>
>>>> [1] http://dpdk.org/ml/archives/users/2017-April/001786.html
>>>>
>>>> Thanks,
>>>>
>>>> Tetsuro
>>>>
>>>> # re-sending the e-mail because I failed to submit the e-mail to
>>>> users@dpdk.org.
>>>>
>>>> --
>>>> Tetsuro Nakamura <nakamura.tetsuro@lab.ntt.co.jp> NTT Network Service
>>>> Systems Laboratories
>>>> TEL:0422 59 6914(National)/+81 422 59 6914(International) 3-9-11,
>>>> Midori-Cho Musashino-Shi, Tokyo 180-8585 Japan
>>>>
>>
> 

Re: using rte_flow via tespmd with Intel X552

[Adrien Mazarguil]

On Tue, Aug 08, 2017 at 09:57:34AM +0100, Ferruh Yigit wrote:
> On 8/2/2017 2:41 PM, Adrien Mazarguil wrote:
> > Hi Wenzhuo,
> > 
> > On Wed, Aug 02, 2017 at 01:00:47PM +0000, Lu, Wenzhuo wrote:
> >> Hi,
> >>
> >>> -----Original Message-----
> >>> From: Zhao1, Wei
> >>> Sent: Wednesday, August 2, 2017 3:28 AM
> >>> To: TETSURO NAKAMURA <nakamura.tetsuro@lab.ntt.co.jp>
> >>> Cc: TAKADA Naoki <takada.naoki@lab.ntt.co.jp>; Satoshi NISHIYAMA
> >>> <nishiyama.s@lab.ntt.co.jp>; Lu, Wenzhuo <wenzhuo.lu@intel.com>;
> >>> dev@dpdk.org
> >>> Subject: RE: using rte_flow via tespmd with Intel X552
> >>>
> >>> Hi, NAKAMURA
> >>>
> >>> I have upload 2 documents about command format when creating flow for
> >>> NIC igb and ixgbe in the email attachment.
> >>> I have decided to commit the context in the doc to doc\guides\nics\ixgbe.rst
> >>> before, BUT by now it seems the content of the document is too much To
> >>> store there. So, is there any other doc more suitable in DPDK to record this.
> >>> And welcome for any other suggestion.
> >>> AND, Wenzhuo, what is your opinion for this?
> >> I also have the same feeling that it may make the ixgbe.rst too big. 
> >> + John and Adrien. Hi John,  Adrien, I'm think about creating a specific doc for rte flow, we can include the examples for every NIC here. Is it good? If so, where's the good place to put it? Thanks.
> > 
> > Depends on the kind of examples. Code samples or testpmd flow command?
> > Unless you mean a document that describes individual rte_flow features
> > supported by each NIC?
> > 
> > Code samples could be added to a new "Programming flow rules" (or something)
> > section in doc/guide/prog_guide/rte_flow.rst.
> > 
> > Another section about NICs could be added in that documentation as well but
> > should only contain a short summary for each of them and a link to the
> > relevant PMD documentation in nics/$PMD.rst (or elsewhere in the DPDK
> > tree), if any.
> > 
> > If you want to describe individual rte_flow features supported by each NIC,
> > I think there's no other choice but to create a bunch of
> > doc/guides/nics/features/rte_flow/*.ini files.
> 
> Indeed I was thinking doing a change in .ini files related rte flow in 17.11
> 
> rte_flow is a method to implement some filtering features, rte_flow
> itself is not a device feature. And filtering features already listed in
> .ini file.
> 
> So I was thinking removing rte_flow from feature table, and update
> existing filter features as something like:
> "Ethertype filter = L"  --> Feature exist and implemented using Legacy
> method.
> "Ethertype filter = Y"  --> Feature exist and implemented using rte flow
> 
> Does it make sense?

Yes, I'm fine with that. Detailed information about rte_flow support can be
added later to the relevant PMD documentation if necessary then.

-- 
Adrien Mazarguil
6WIND