From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH v1 04/48] net/mlx4: remove useless
 compilation checks
Date: Fri, 1 Sep 2017 12:19:45 +0200
Message-ID: <20170901101945.GP4301@6wind.com>
References: <cover.1501598383.git.adrien.mazarguil@6wind.com>
 <ca8426b5aeecbce63cc1c11164434e76ddce2756.1501598384.git.adrien.mazarguil@6wind.com>
 <203a53f8-41a2-a3f7-fce2-59379de8ba2c@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr0-f181.google.com (mail-wr0-f181.google.com
 [209.85.128.181]) by dpdk.org (Postfix) with ESMTP id 8A5EC108F
 for <dev@dpdk.org>; Fri,  1 Sep 2017 12:19:56 +0200 (CEST)
Received: by mail-wr0-f181.google.com with SMTP id 40so5218206wrv.5
 for <dev@dpdk.org>; Fri, 01 Sep 2017 03:19:56 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <203a53f8-41a2-a3f7-fce2-59379de8ba2c@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Ferruh,

On Fri, Aug 18, 2017 at 02:39:18PM +0100, Ferruh Yigit wrote:
> On 8/1/2017 5:53 PM, Adrien Mazarguil wrote:
> > Verbs support for RSS, inline receive and extended device query calls has
> > not been optional for a while. Their absence is untested and is therefore
> > unsupported.
> > 
> > Remove the related compilation checks and assume Mellanox OFED is up to
> > date, as described in the documentation.
> 
> So this requires Mellanox OFED 4.1 is there,

Well, the PMD most likely works with versions older than that, but they are
not officially supported anymore. These changes assert that no effort is
made to maintain compatibility.

> is there a check for the OFED version, or do you think does it required?

I think it's not necessary. You know, the existing checks haven't been
validated for a very long time, mlx4 probably does not even compile anymore
without these features. Even if it does, it might be unable to perform TX/RX
at all. Getting a compilation failure at least makes things clear.

> 
> > 
> > Use this opportunity to remove a few useless data path debugging messages
> > behind compilation checks on never defined macros.
> > 
> > Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> 
> <...>
> 

-- 
Adrien Mazarguil
6WIND