From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xueming Li Subject: [PATCH] net/mlx5: fix tunnel offload detection Date: Mon, 4 Sep 2017 19:43:51 +0800 Message-ID: <20170904114351.104617-1-xuemingl@mellanox.com> Cc: Xueming Li , dev@dpdk.org To: Nelio Laranjeiro , Adrien Mazarguil Return-path: Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id E45687CA9 for ; Mon, 4 Sep 2017 13:46:45 +0200 (CEST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" PMD driver got random tunnel_en value on ConnextX-4LX NIC, depends on compile optimization level. The variable was not initialized and detection logic was absent. Fixes: 578ff15e ("net/mlx5: add hardware checksum offload for tunnel packets") Signed-off-by: Xueming Li Acked-by: Shahaf Shuler --- drivers/net/mlx5/mlx5.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index d7968f5..084df88 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -445,7 +445,7 @@ struct mlx5_args { struct ibv_device_attr device_attr; unsigned int sriov; unsigned int mps; - unsigned int tunnel_en; + unsigned int tunnel_en = 0; int idx; int i; @@ -503,6 +503,7 @@ struct mlx5_args { mps = MLX5_MPW_DISABLED; break; case PCI_DEVICE_ID_MELLANOX_CONNECTX4LX: + tunnel_en = 1; mps = MLX5_MPW; break; case PCI_DEVICE_ID_MELLANOX_CONNECTX5: -- 1.8.3.1