From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier MATZ <olivier.matz@6wind.com>
Subject: Re: [PATCH v4 2/7] mempool: add mempool arg in xmem size
	and usage
Date: Mon, 4 Sep 2017 16:22:33 +0200
Message-ID: <20170904142232.jri222kqnvc5sorv@neon>
References: <20170720134759.4680-1-santosh.shukla@caviumnetworks.com>
 <20170815060743.21076-1-santosh.shukla@caviumnetworks.com>
 <20170815060743.21076-3-santosh.shukla@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, thomas@monjalon.net, jerin.jacob@caviumnetworks.com,
 hemant.agrawal@nxp.com
To: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id CFAF6376C
 for <dev@dpdk.org>; Mon,  4 Sep 2017 16:22:41 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20170815060743.21076-3-santosh.shukla@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Aug 15, 2017 at 11:37:38AM +0530, Santosh Shukla wrote:
> xmem_size and xmem_usage need to know the status of mp->flag.
> Following patch will make use of that.
> 
> Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> ---
>  drivers/net/xenvirt/rte_mempool_gntalloc.c |  5 +++--
>  lib/librte_mempool/rte_mempool.c           | 10 ++++++----
>  lib/librte_mempool/rte_mempool.h           |  8 ++++++--
>  test/test/test_mempool.c                   |  4 ++--
>  4 files changed, 17 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/net/xenvirt/rte_mempool_gntalloc.c b/drivers/net/xenvirt/rte_mempool_gntalloc.c
> index 73e82f808..ee0bda459 100644
> --- a/drivers/net/xenvirt/rte_mempool_gntalloc.c
> +++ b/drivers/net/xenvirt/rte_mempool_gntalloc.c
> @@ -114,7 +114,7 @@ _create_mempool(const char *name, unsigned elt_num, unsigned elt_size,
>  	pg_shift = rte_bsf32(pg_sz);
>  
>  	rte_mempool_calc_obj_size(elt_size, flags, &objsz);
> -	sz = rte_mempool_xmem_size(elt_num, objsz.total_size, pg_shift);
> +	sz = rte_mempool_xmem_size(elt_num, objsz.total_size, pg_shift, NULL);
>  	pg_num = sz >> pg_shift;
>  
>  	pa_arr = calloc(pg_num, sizeof(pa_arr[0]));

What is the meaning of passing NULL to rte_mempool_xmem_size()?
Does it mean that flags are ignored?

Wouldn't it be better to pass the mempool flags instead of the mempool
pointer?