From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro Subject: Re: [PATCH v2 1/2] net/mlx5: fix num seg assumption on vPMD Date: Mon, 4 Sep 2017 16:57:48 +0200 Message-ID: <20170904145748.fjd3mwroy2pwwdw4@localhost> References: <20170823073358.116786-1-shahafs@mellanox.com> <1e7320c4ee4162c9e509b7560be215077f43ca87.1504076528.git.shahafs@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: adrien.mazarguil@6wind.com, dev@dpdk.org, stable@dpdk.org To: Shahaf Shuler Return-path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 382A67CFD for ; Mon, 4 Sep 2017 16:57:51 +0200 (CEST) Received: by mail-wm0-f48.google.com with SMTP id f145so5115933wme.0 for ; Mon, 04 Sep 2017 07:57:51 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1e7320c4ee4162c9e509b7560be215077f43ca87.1504076528.git.shahafs@mellanox.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Aug 30, 2017 at 10:07:07AM +0300, Shahaf Shuler wrote: > vPMD Tx function assumes that after the scatter of the > multi-segment packets the next packet will be a single segment packet. > > This is not current as the function can return due to lack of resources > without sending all of the multi-segment mbufs sequence. > > Fixes: 6cb559d67b83 ("net/mlx5: add vectorized Rx/Tx burst for x86") > Cc: stable@dpdk.org > > Signed-off-by: Shahaf Shuler > Acked-by: Yongseok Koh > --- > This patch should be applied only after the series: > http://dpdk.org/dev/patchwork/patch/27367/ > > on v2: > - different approach to fix the issue. > --- > drivers/net/mlx5/mlx5_rxtx_vec_sse.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_sse.c b/drivers/net/mlx5/mlx5_rxtx_vec_sse.c > index 37854a73b..f89762ff8 100644 > --- a/drivers/net/mlx5/mlx5_rxtx_vec_sse.c > +++ b/drivers/net/mlx5/mlx5_rxtx_vec_sse.c > @@ -112,8 +112,7 @@ txq_wr_dseg_v(struct txq *txq, __m128i *dseg, > } > > /** > - * Count the number of continuous single segment packets. The first packet must > - * be a single segment packet. > + * Count the number of continuous single segment packets. > * > * @param pkts > * Pointer to array of packets. > @@ -130,9 +129,8 @@ txq_check_multiseg(struct rte_mbuf **pkts, uint16_t pkts_n) > > if (!pkts_n) > return 0; > - assert(NB_SEGS(pkts[0]) == 1); > /* Count the number of continuous single segment packets. */ > - for (pos = 1; pos < pkts_n; ++pos) > + for (pos = 0; pos < pkts_n; ++pos) > if (NB_SEGS(pkts[pos]) > 1) > break; > return pos; > -- > 2.12.0 Acked-by: Nelio Laranjeiro -- Nélio Laranjeiro 6WIND