From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH v2 3/3] net/mlx5: fix interrupt enable return value Date: Tue, 5 Sep 2017 15:27:20 +0200 Message-ID: <20170905132720.GD4301@6wind.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, Nelio Laranjeiro , stable@dpdk.org To: Shachar Beiser Return-path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id A81532BAF for ; Tue, 5 Sep 2017 15:27:31 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id i145so19465693wmf.1 for ; Tue, 05 Sep 2017 06:27:31 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Shachar, On Tue, Sep 05, 2017 at 01:04:38PM +0000, Shachar Beiser wrote: > return value is sometimes returned uninitialized > > Fixes: e1016cb73383 ("net/mlx5: fix Rx interrupts management") > Fixes: b18042fb8f49 ("net/mlx5: fix misplaced Rx interrupts functions") > > Cc: adrien.mazarguil@6wind.com > Cc: stable@dpdk.org > > Signed-off-by: Shachar Beiser Looks like in both commits, ret is properly initialized so I'm wondering if the fixes line is right? Did you even get a compilation error? Otherwise, you should drop this patch from the series. > --- > drivers/net/mlx5/mlx5_rxq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c > index 437dc02..24887fb 100644 > --- a/drivers/net/mlx5/mlx5_rxq.c > +++ b/drivers/net/mlx5/mlx5_rxq.c > @@ -1330,7 +1330,7 @@ > struct priv *priv = mlx5_get_priv(dev); > struct rxq *rxq = (*priv->rxqs)[rx_queue_id]; > struct rxq_ctrl *rxq_ctrl = container_of(rxq, struct rxq_ctrl, rxq); > - int ret; > + int ret = 0; > > if (!rxq || !rxq_ctrl->channel) { > ret = EINVAL; > -- > 1.8.3.1 > -- Adrien Mazarguil 6WIND