From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH v4 1/2] net/mlx5: link status update separation Date: Wed, 6 Sep 2017 17:14:14 +0200 Message-ID: <20170906151414.GY4301@6wind.com> References: <1504710238-25726-1-git-send-email-matan@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Nelio Laranjeiro , dev@dpdk.org To: Matan Azrad Return-path: Received: from mail-wr0-f180.google.com (mail-wr0-f180.google.com [209.85.128.180]) by dpdk.org (Postfix) with ESMTP id CA5A958F6 for ; Wed, 6 Sep 2017 17:14:24 +0200 (CEST) Received: by mail-wr0-f180.google.com with SMTP id o42so3995996wrb.3 for ; Wed, 06 Sep 2017 08:14:24 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1504710238-25726-1-git-send-email-matan@mellanox.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Sep 06, 2017 at 06:03:57PM +0300, Matan Azrad wrote: > Link status is sometimes inconsistent during a LSC event. > When it occurs, the PMD refrains from immediately notifying > the application; instead, an alarm is scheduled to check > link status later and notify the application once it has settled. > > In the previous code the alarm callback calls to the interrupt > handler for link status recheck and may cause to unnecessary > interrupt events check. > > This patch separates the link status update and the interrupt event > handler to avoid the unnecessary check and arranges the interrupt > handler for more interrupt supports in the future. > > Comment was added in the new function to explain the inconsistent > link status reason. > > Signed-off-by: Matan Azrad Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND