From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] eal: cleanup strerror function Date: Thu, 7 Sep 2017 10:51:52 -0700 Message-ID: <20170907105152.4faa7110@xeon-e3> References: <20170907130956.157969-1-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Bruce Richardson Return-path: Received: from mail-pf0-f178.google.com (mail-pf0-f178.google.com [209.85.192.178]) by dpdk.org (Postfix) with ESMTP id C11122BFF for ; Thu, 7 Sep 2017 19:51:54 +0200 (CEST) Received: by mail-pf0-f178.google.com with SMTP id e1so624359pfk.1 for ; Thu, 07 Sep 2017 10:51:54 -0700 (PDT) In-Reply-To: <20170907130956.157969-1-bruce.richardson@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 7 Sep 2017 14:09:56 +0100 Bruce Richardson wrote: > + /* BSD puts a colon in the "unknown error" messages, Linux doesn't */ > +#ifdef RTE_EXEC_ENV_BSDAPP > + static const char *sep = ":"; > +#else > + static const char *sep = ""; > +#endif This is seems unnecessary to me just have the message be different.