From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH 01/21] Revert "vhost: workaround MQ fails to startup" Date: Thu, 7 Sep 2017 19:54:48 +0800 Message-ID: <20170907115448.GA9736@yliu-home> References: <20170831095023.21037-1-maxime.coquelin@redhat.com> <20170831095023.21037-2-maxime.coquelin@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, jfreiman@redhat.com, tiwei.bie@intel.com, mst@redhat.com, vkaplans@redhat.com, jasowang@redhat.com To: Maxime Coquelin Return-path: Received: from mail-pg0-f54.google.com (mail-pg0-f54.google.com [74.125.83.54]) by dpdk.org (Postfix) with ESMTP id 2CE5C199AB for ; Thu, 7 Sep 2017 13:55:04 +0200 (CEST) Received: by mail-pg0-f54.google.com with SMTP id v66so20308074pgb.5 for ; Thu, 07 Sep 2017 04:55:04 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20170831095023.21037-2-maxime.coquelin@redhat.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Aug 31, 2017 at 11:50:03AM +0200, Maxime Coquelin wrote: > This reverts commit 04d81227960b5c1cf2f11f492100979ead20c526. > > As agreed when this workaround was introduced, it can be reverted > as Qemu v2.10 that fixes the issue is now out. First of all, I'm very sorry for being so late on review! I didn't quite remember we have come an agreement on that. I think my old concern still counts: how do you handle the combo like DPDK v17.11 and QEMU v2.7-2.9 (assume we take this patch in DPDK v17.11) ? Note that it's not a trivial bug, it's a fatal bug that freezes QEMU, IIRC. --yliu > The reply-ack feature is required for vhost-user IOMMU support. > > Signed-off-by: Maxime Coquelin