From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH] eal: cleanup strerror function
Date: Fri, 8 Sep 2017 10:03:45 +0100
Message-ID: <20170908090345.GE35580@bricha3-MOBL3.ger.corp.intel.com>
References: <20170907130956.157969-1-bruce.richardson@intel.com>
 <20170907105152.4faa7110@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 66C91377E
 for <dev@dpdk.org>; Fri,  8 Sep 2017 11:03:49 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20170907105152.4faa7110@xeon-e3>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Sep 07, 2017 at 10:51:52AM -0700, Stephen Hemminger wrote:
> On Thu,  7 Sep 2017 14:09:56 +0100
> Bruce Richardson <bruce.richardson@intel.com> wrote:
> 
> > +	/* BSD puts a colon in the "unknown error" messages, Linux doesn't */
> > +#ifdef RTE_EXEC_ENV_BSDAPP
> > +	static const char *sep = ":";
> > +#else
> > +	static const char *sep = "";
> > +#endif
> 
> This is seems unnecessary to me just have the message be different.

I'd rather keep it consistent for the sake of the couple of lines of
code. What would be better is if there was a C variable we could use for
this to avoid macros, but I not aware of one right now that could work.
Again, open to suggestions on that. Even with keeping the macros, this
is still cleaner than the previous version.

/Bruce