From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v2 1/2] eal/malloc: fix RTE malloc debug macro Date: Fri, 8 Sep 2017 09:03:51 -0700 Message-ID: <20170908090351.457fe42c@xeon-e3> References: <20170823022926.169272-1-xuemingl@mellanox.com> <20170908145055.50280-1-xuemingl@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Sergio Gonzalez Monroy , dev@dpdk.org To: Xueming Li Return-path: Received: from mail-pg0-f43.google.com (mail-pg0-f43.google.com [74.125.83.43]) by dpdk.org (Postfix) with ESMTP id E533926A8 for ; Fri, 8 Sep 2017 18:04:01 +0200 (CEST) Received: by mail-pg0-f43.google.com with SMTP id v66so5512411pgb.5 for ; Fri, 08 Sep 2017 09:04:01 -0700 (PDT) In-Reply-To: <20170908145055.50280-1-xuemingl@mellanox.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 8 Sep 2017 22:50:54 +0800 Xueming Li wrote: > - printf("rte_zmalloc didn't zero" > + printf("rte_zmalloc didn't zero " > "the allocated memory\n"); Please don't break error messages onto two lines. It makes it harder to use tools like grep and google searches to find where message is located. Checkpatch and other tools make an exception for long lines in quoted strings.