From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH v2 2/2] ethdev: introduce Tx queue offloads
	API
Date: Mon, 11 Sep 2017 14:35:44 +0530
Message-ID: <20170911090543.GA9965@jerin>
References: <cover.1504508374.git.shahafs@mellanox.com>
 <cover.1505044395.git.shahafs@mellanox.com>
 <ce7981e06173fc681d5fdf165eef22c602211a5d.1505044395.git.shahafs@mellanox.com>
 <20170910104827.11da9230@xeon-e3>
 <VI1PR05MB3149019C340D6C407CDC15F6C3680@VI1PR05MB3149.eurprd05.prod.outlook.com>
 <20170911062119.GA9342@jerin>
 <VI1PR05MB31494668FAE2606997105A91C3680@VI1PR05MB3149.eurprd05.prod.outlook.com>
 <20170911080621.GA15867@jerin>
 <VI1PR05MB31490468C3935396E8DA9A0DC3680@VI1PR05MB3149.eurprd05.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Stephen Hemminger <stephen@networkplumber.org>,
 Thomas Monjalon <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>
To: Shahaf Shuler <shahafs@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-BN3-obe.outbound.protection.outlook.com
 (mail-bn3nam01on0041.outbound.protection.outlook.com [104.47.33.41])
 by dpdk.org (Postfix) with ESMTP id C5C6E7CB3
 for <dev@dpdk.org>; Mon, 11 Sep 2017 11:06:06 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <VI1PR05MB31490468C3935396E8DA9A0DC3680@VI1PR05MB3149.eurprd05.prod.outlook.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Mon, 11 Sep 2017 08:46:50 +0000
> From: Shahaf Shuler <shahafs@mellanox.com>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> CC: Stephen Hemminger <stephen@networkplumber.org>, Thomas Monjalon
>  <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>
> Subject: RE: [dpdk-dev] [PATCH v2 2/2] ethdev: introduce Tx queue offloads
>  API
> 
> Monday, September 11, 2017 11:06 AM, Jerin Jacob:
> > >
> > > I don't understand.
> > > From the exact link above, you explicitly say that *you* will move this flags
> > once the series is integrated. Quoting:
> > >
> > > "
> > > > Please Jerin, could you work on moving these settings in a new API?
> > >
> > > Sure. Once the generic code is in place. We are committed to fix the
> > > PMDs by 18.02.
> > 
> > Yes. I will take care of the PMD(nicvf) side of the changes. Not in ethdev or
> > mempool. Meaning, you need to decide how you are going to expose the
> > equivalent of these flags and enable the generic code for those flags in
> > ethdev or mempool. The drivers side of changes I can take care.
> > 
> 
> How about doing it a PMD option? 
> Seems like nicvf is the only PMD which care about them.

Lets take flag by flag:
ETH_TXQ_FLAGS_NOMULTMEMP - I think, this should be removed. But we can have
common code in ethdev pmd to detect all pool being configured from on the same pool
as on the rx_configure() application passes the mempool.

ETH_TXQ_FLAGS_NOREFCOUNT: This one has i40e and nicvf consumers.
And it is driven by the use case too. So it should available in some
form.

> 
> If there will be more PMDs later, we can think about which API is needed.  
>