From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olivier Matz Subject: [PATCH 07/10] metrics: fix compilation with -Og Date: Mon, 11 Sep 2017 17:13:30 +0200 Message-ID: <20170911151333.5727-8-olivier.matz@6wind.com> References: <20170911151333.5727-1-olivier.matz@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit To: dev@dpdk.org Return-path: Received: from proxy.6wind.com (host.76.145.23.62.rev.coltfrance.com [62.23.145.76]) by dpdk.org (Postfix) with ESMTP id E66E41AF03 for ; Mon, 11 Sep 2017 17:13:51 +0200 (CEST) Received: from glumotte.dev.6wind.com (unknown [10.16.0.195]) by proxy.6wind.com (Postfix) with ESMTP id EB26CCF32F for ; Mon, 11 Sep 2017 17:09:57 +0200 (CEST) In-Reply-To: <20170911151333.5727-1-olivier.matz@6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The compilation with gcc-6.3.0 and EXTRA_CFLAGS=-Og gives the following error: CC rte_metrics.o rte_metrics.c: In function ‘rte_metrics_reg_names’: rte_metrics.c:153:22: error: ‘entry’ may be used uninitialized in this function [-Werror=maybe-uninitialized] entry->idx_next_set = 0; ~~~~~~~~~~~~~~~~~~~~^~~ This is a false positive, gcc is not able to see that we always go in the loop at least once, initializing entry. Fix the warning by initializing entry to NULL. Signed-off-by: Olivier Matz --- lib/librte_metrics/rte_metrics.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_metrics/rte_metrics.c b/lib/librte_metrics/rte_metrics.c index b66a72bb0..d9404001a 100644 --- a/lib/librte_metrics/rte_metrics.c +++ b/lib/librte_metrics/rte_metrics.c @@ -115,7 +115,7 @@ rte_metrics_reg_name(const char *name) int rte_metrics_reg_names(const char * const *names, uint16_t cnt_names) { - struct rte_metrics_meta_s *entry; + struct rte_metrics_meta_s *entry = NULL; struct rte_metrics_data_s *stats; const struct rte_memzone *memzone; uint16_t idx_name; -- 2.11.0