From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v7 3/6] igb_uio: fix MSI-X IRQ assignment
 with new IRQ function
Date: Tue, 12 Sep 2017 09:14:51 +0100
Message-ID: <20170912081451.GA40060@bricha3-MOBL3.ger.corp.intel.com>
References: <1503336825-7700-1-git-send-email-markus.theil@tu-ilmenau.de>
 <1504613046-7259-1-git-send-email-markus.theil@tu-ilmenau.de>
 <1504613046-7259-3-git-send-email-markus.theil@tu-ilmenau.de>
 <dd57961d-04f4-cc90-a547-2fdcc33a1570@intel.com>
 <CAOaVG14ROuQnqYTC3Ow4ppunnFmCMV+4XCHLfp4QtGKxZMmOWw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
 Markus Theil <markus.theil@tu-ilmenau.de>, dev@dpdk.org,
 nicolas.dichtel@6wind.com
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 54AE41D8A
 for <dev@dpdk.org>; Tue, 12 Sep 2017 10:14:58 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <CAOaVG14ROuQnqYTC3Ow4ppunnFmCMV+4XCHLfp4QtGKxZMmOWw@mail.gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Sep 11, 2017 at 03:04:01PM -0700, Stephen Hemminger wrote:
> I wonder if it is time to move the bar forward to oldest LTS which is
> 3.2.92
> 

That seems reasonable. Probably best to do a deprecation notice for it
in 17.11 and move the bar in 18.02.

/Bruce

> 
> On Sep 11, 2017 10:56 AM, "Ferruh Yigit" <ferruh.yigit@intel.com> wrote:
> 
> > On 9/5/2017 1:04 PM, Markus Theil wrote:
> > > The patch which introduced the usage of pci_alloc_irq_vectors
> > > came after the patch which switched to non-threaded ISR (f0d1896fa1),
> > > but did not use non-threaded ISR, if pci_alloc_irq_vectors
> > > is used.
> > >
> > > Fixes: 99bb58f3adc7 ("igb_uio: switch to new irq function for
> > > MSI-X")
> > > Cc: nicolas.dichtel@6wind.com
> > >
> > > Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de>
> > > ---
> > >  lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
> > b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
> > > index 93bb71d..6885e72 100644
> > > --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
> > > +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
> > > @@ -331,6 +331,7 @@ igbuio_pci_enable_interrupts(struct rte_uio_pci_dev
> > *udev)
> > >  #else
> > >               if (pci_alloc_irq_vectors(udev->pdev, 1, 1, PCI_IRQ_MSIX)
> > == 1) {
> > >                       dev_dbg(&udev->pdev->dev, "using MSI-X");
> > > +                     udev->info.irq_flags = IRQF_NO_THREAD;
> >
> > IRQF_NO_THREAD seems has been introduced in 2.6.39, so using this flag
> > causing build error for kernel versions < 2.6.39.
> >
> > btw, the flag is already in use, so issue is not related to this patch.
> >
> > In DPDK documentation supported Linux kernel version is >= 2.6.34 [1].
> >
> > We should either increase supported version to 2.6.39, or update igb_uio
> > code.
> >
> > I am for increasing minimum supported kernel version to 2.6.39, any
> > objection / comment?
> >
> > 2.6.39 released on May 2011
> > 2.6.34 released on May 2010
> >
> >
> > [1]
> > http://dpdk.org/doc/guides/linux_gsg/sys_reqs.html#system-software
> >
> > >                       udev->info.irq = pci_irq_vector(udev->pdev, 0);
> > >                       udev->mode = RTE_INTR_MODE_MSIX;
> > >                       break;
> > >
> >
> >