From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH 1/2] net/sfc: free mbufs in bulks on EF10
 native Tx datapath reap
Date: Tue, 12 Sep 2017 14:51:57 -0700
Message-ID: <20170912145157.0794e9f7@plumbers-lap.home.lan>
References: <1504880151-15394-1-git-send-email-arybchenko@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, Ivan Malov <ivan.malov@oktetlabs.ru>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pg0-f52.google.com (mail-pg0-f52.google.com [74.125.83.52])
 by dpdk.org (Postfix) with ESMTP id EC8CEDE0
 for <dev@dpdk.org>; Tue, 12 Sep 2017 23:52:00 +0200 (CEST)
Received: by mail-pg0-f52.google.com with SMTP id d8so23679416pgt.4
 for <dev@dpdk.org>; Tue, 12 Sep 2017 14:52:00 -0700 (PDT)
In-Reply-To: <1504880151-15394-1-git-send-email-arybchenko@solarflare.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 8 Sep 2017 15:15:50 +0100
Andrew Rybchenko <arybchenko@solarflare.com> wrote:

> +			txd->mbuf = NULL;
> +			if (m == NULL)
> +				continue;
> +
> +			if ((nb == RTE_DIM(bulk)) ||
> +			    ((nb != 0) && (m->pool != bulk[0]->pool))) {
> +				rte_mempool_put_bulk(bulk[0]->pool,
> +						     (void *)bulk, nb);
> +				nb = 0;
>  			}
> +

Why not add rte_mbuf_free_bulk (inline) to base code, rather than recoding
everywhere?