From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shijith Thotton <shijith.thotton@caviumnetworks.com>
Subject: Re: vf init issue with patch igb_uio: issue FLR during
 open and release of device file
Date: Wed, 13 Sep 2017 16:18:41 +0530
Message-ID: <20170913104840.GA14229@localhost.localdomain>
References: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16F7E0E71@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "dev@dpdk.org" <dev@dpdk.org>, Jianfeng Tan <jianfeng.tan@intel.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>
To: "Yang, Qiming" <qiming.yang@intel.com>, Gregory Etelson <gregory@weka.io>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-BL2-obe.outbound.protection.outlook.com
 (mail-bl2nam02on0071.outbound.protection.outlook.com [104.47.38.71])
 by dpdk.org (Postfix) with ESMTP id DF6DD7D4E
 for <dev@dpdk.org>; Wed, 13 Sep 2017 12:49:03 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF16F7E0E71@SHSMSX101.ccr.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Sep 13, 2017 at 07:51:30AM +0000, Yang, Qiming wrote:
>    Hi, Shijith
> 
>     
> 
>    VF init error will happen after apply your patch, error log as below. If
>    revert your commit, all things work well. And this issue is not only occur
>    in i40 VF but also ixgbe.
> 
>    Could you help to check it soon?
> 
>     
> 
>    [root@localhost app]# ./testpmd -c 7 -n 4 -- -i
> 
>    EAL: Detected 10 lcore(s)
> 
>    EAL: No free hugepages reported in hugepages-1048576kB
> 
>    EAL: Probing VFIO support...
> 
>    EAL: WARNING: cpu flags constant_tsc=yes nonstop_tsc=no -> using
>    unreliable clock cycles !
> 
>    EAL: PCI device 0000:00:03.0 on NUMA socket -1
> 
>    EAL:   Invalid NUMA socket, default to 0
> 
>    EAL:   probe driver: 8086:154c net_i40e_vf
> 
>    i40evf_init_vf(): init_adminq failed: -53
> 
>    i40evf_dev_init(): Init vf failed
> 
>    EAL: Requested device 0000:00:03.0 cannot be used
> 
>     
> 
>    commit b58eedfc7dd57eef6d12e2c654a52c834f36084a
>    Author: Shijith Thotton <shijith.thotton@caviumnetworks.com>
>    Date: Fri Jul 7 16:43:51 2017 +0530
> 
>    igb_uio: issue FLR during open and release of device file
> 
>    Set UIO info device file operations open and release. Call pci reset
>    function inside open and release to clear device state at start and end.
>    Copied this behaviour from vfio_pci kernel module code. With this patch,
>    it is not mandatory to issue FLR by PMD's during init and close.
> 
>    Bus master enable and disable are added in open and release respectively
>    to take care of device DMA.
> 
>    Signed-off-by: Shijith Thotton <shijith.thotton@caviumnetworks.com>
>    Reviewed-by: Jianfeng Tan <jianfeng.tan@intel.com>
>    Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>    Acked-by: Gregory Etelson <gregory@weka.io>
> 
>     
> 
>    Best Regard,
> 
>    Yang Qiming
> 
>     

Hi Yang Qiming,

We didn't face this issue while preparing patch. I think, Gregory tested
it for Intel NICs. Adding more people to the loop for help.

Shijith