From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shijith Thotton Subject: Re: [PATCH v2] net/liquidio: fix uninitialized variable Date: Mon, 18 Sep 2017 11:57:22 +0530 Message-ID: <20170918062721.GA6037@localhost.localdomain> References: <1505476108-11005-1-git-send-email-wang.yong19@zte.com.cn> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: shijith.thotton@cavium.com, dev@dpdk.org To: Yong Wang Return-path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0071.outbound.protection.outlook.com [104.47.38.71]) by dpdk.org (Postfix) with ESMTP id 800F1DE3 for ; Mon, 18 Sep 2017 08:27:42 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1505476108-11005-1-git-send-email-wang.yong19@zte.com.cn> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Sep 15, 2017 at 07:48:28AM -0400, Yong Wang wrote: > In func lio_dev_link_update(), "link.link_autoneg" is used in func call > lio_dev_atomic_write_link_status(), but is uninitialized. > > v2: > * Modify the initial value of 'link.link_autoneg' from 'ETH_LINK_FIXED' > to 'ETH_LINK_AUTONEG'. Please remove change log from commit message[1] and use --in-reply-to option while sending new versions of a patch. 1. http://dpdk.org/ml/archives/dev/2017-September/075426.html > > Signed-off-by: Yong Wang > --- You can move change log here. > drivers/net/liquidio/lio_ethdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/liquidio/lio_ethdev.c b/drivers/net/liquidio/lio_ethdev.c > index 479936a..30119d2 100644 > --- a/drivers/net/liquidio/lio_ethdev.c > +++ b/drivers/net/liquidio/lio_ethdev.c > @@ -939,6 +939,7 @@ struct rte_lio_xstats_name_off { > link.link_status = ETH_LINK_DOWN; > link.link_speed = ETH_SPEED_NUM_NONE; > link.link_duplex = ETH_LINK_HALF_DUPLEX; > + link.link_autoneg = ETH_LINK_AUTONEG; > memset(&old, 0, sizeof(old)); > > /* Return what we found */ > -- > 1.8.3.1 >