From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH 06/11] ethdev: extend ethdev to support
	security APIs
Date: Mon, 18 Sep 2017 13:27:25 +0530
Message-ID: <20170918075721.GA7658@jerin>
References: <20170914082651.26232-1-akhil.goyal@nxp.com>
 <20170914082651.26232-7-akhil.goyal@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, declan.doherty@intel.com, pablo.de.lara.guarch@intel.com,
 hemant.agrawal@nxp.com, radu.nicolau@intel.com, borisp@mellanox.com,
 aviadye@mellanox.com, thomas@monjalon.net, sandeep.malik@nxp.com
To: Akhil Goyal <akhil.goyal@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-CY1-obe.outbound.protection.outlook.com
 (mail-cys01nam02on0084.outbound.protection.outlook.com [104.47.37.84])
 by dpdk.org (Postfix) with ESMTP id BAB1BF04
 for <dev@dpdk.org>; Mon, 18 Sep 2017 09:58:19 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20170914082651.26232-7-akhil.goyal@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Thu, 14 Sep 2017 13:56:46 +0530
> From: Akhil Goyal <akhil.goyal@nxp.com>
> To: dev@dpdk.org
> CC: declan.doherty@intel.com, pablo.de.lara.guarch@intel.com,
>  hemant.agrawal@nxp.com, radu.nicolau@intel.com, borisp@mellanox.com,
>  aviadye@mellanox.com, thomas@monjalon.net, sandeep.malik@nxp.com,
>  jerin.jacob@caviumnetworks.com
> Subject: [PATCH 06/11] ethdev: extend ethdev to support security APIs
> X-Mailer: git-send-email 2.9.3
> 
> From: Declan Doherty <declan.doherty@intel.com>
>  /**
> @@ -907,6 +912,7 @@ struct rte_eth_conf {
>  #define DEV_RX_OFFLOAD_QINQ_STRIP  0x00000020
>  #define DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM 0x00000040
>  #define DEV_RX_OFFLOAD_MACSEC_STRIP     0x00000080
> +#define DEV_RX_OFFLOAD_SECURITY         0x00000100
>  
>  /**
>   * TX offload capabilities of a device.
> @@ -926,6 +932,11 @@ struct rte_eth_conf {
>  #define DEV_TX_OFFLOAD_GENEVE_TNL_TSO   0x00001000    /**< Used for tunneling packet. */
>  #define DEV_TX_OFFLOAD_MACSEC_INSERT    0x00002000
>  #define DEV_TX_OFFLOAD_MT_LOCKFREE      0x00004000
> +#define DEV_TX_OFFLOAD_SECURITY         0x00008000

For the documentation side, Sharing the same views as Shahaf's

> +#define DEV_TX_OFFLOAD_SEC_NEED_MDATA   0x00010000

If i understand correctly, it is more of a fixup if driver needs.I guess
we can change to negative logic reflect it as offload.

> +#define DEV_TX_OFFLOAD_IPSEC_CRYPTO_HW_TRAILER 0x00020000
> +#define DEV_TX_OFFLOAD_IPSEC_CRYPTO_TSO        0x00040000
> +#define DEV_TX_OFFLOAD_IPSEC_CRYPTO_CKSUM      0x00080000
>  /**< Multiple threads can invoke rte_eth_tx_burst() concurrently on the same
>   * tx queue without SW lock.
>   */

The above text should come after DEV_TX_OFFLOAD_MT_LOCKFREE(Position got
changed in this patch)

> @@ -1651,6 +1662,9 @@ struct rte_eth_dev {
>  	enum rte_eth_dev_state state; /**< Flag indicating the port state */
>  } __rte_cache_aligned;
>