From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?Ga=EBtan?= Rivet <gaetan.rivet@6wind.com>
Subject: Re: [PATCH v2 01/14] eal: expose rte_eal_using_phys_addrs
Date: Mon, 18 Sep 2017 13:37:13 +0200
Message-ID: <20170918113713.GR21444@bidouze.vm.6wind.com>
References: <cover.1503651392.git.gaetan.rivet@6wind.com>
 <cover.1505726803.git.gaetan.rivet@6wind.com>
 <d50965340fd71c6556da620243b70d6d6263282d.1505726803.git.gaetan.rivet@6wind.com>
 <53c6676d-14fe-7037-29db-ae3265257a82@nxp.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54])
 by dpdk.org (Postfix) with ESMTP id 920641AEEB
 for <dev@dpdk.org>; Mon, 18 Sep 2017 13:37:24 +0200 (CEST)
Received: by mail-wm0-f54.google.com with SMTP id 13so1791302wmq.2
 for <dev@dpdk.org>; Mon, 18 Sep 2017 04:37:24 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <53c6676d-14fe-7037-29db-ae3265257a82@nxp.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Sep 18, 2017 at 04:17:08PM +0530, Shreyansh Jain wrote:
> Hello Gaetan,
> 
> On Monday 18 September 2017 03:01 PM, Gaetan Rivet wrote:
> >This function was previously private to the EAL layer.
> >Other subsystems requires it, such as the PCI bus.
> >
> >In order not to force other components to include stdbool, which is
> >incompatible with several NIC drivers, the return type has
> >been changed from bool to int.
> >
> >Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
> >---
> 
> [...]
> 
> >diff --git a/lib/librte_eal/linuxapp/eal/eal_memory.c b/lib/librte_eal/linuxapp/eal/eal_memory.c
> >index 5279128..af8719b 100644
> >--- a/lib/librte_eal/linuxapp/eal/eal_memory.c
> >+++ b/lib/librte_eal/linuxapp/eal/eal_memory.c
> >@@ -1542,7 +1542,7 @@ rte_eal_hugepage_attach(void)
> >  	return -1;
> >  }
> >-bool
> >+int
> >  rte_eal_using_phys_addrs(void)
> >  {
> >  	return phys_addrs_available;
> >diff --git a/lib/librte_eal/linuxapp/eal/rte_eal_version.map b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> >index 8c08b8d..f866b70 100644
> >--- a/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> >+++ b/lib/librte_eal/linuxapp/eal/rte_eal_version.map
> >@@ -205,6 +205,7 @@ DPDK_17.08 {
> 
> This symbol should be added to 17.11, isn't it?
> 

Ah, yes indeed

> >  	rte_bus_find;
> >  	rte_bus_find_by_device;
> >  	rte_bus_find_by_name;
> >+	rte_eal_using_phys_addrs;
> >  	rte_log_get_level;
> >  } DPDK_17.05;
> >
> -
> Shreyansh

-- 
Gaëtan Rivet
6WIND