From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Mrzyglod Subject: [PATCH v2] net/virtio: fix of untrusted scalar value Date: Wed, 20 Sep 2017 15:25:56 +0200 Message-ID: <20170920132556.5310-1-danielx.t.mrzyglod@intel.com> References: <20170920091917.3929-1-danielx.t.mrzyglod@intel.com> Cc: dev@dpdk.org, Daniel Mrzyglod , jianfeng.tan@intel.com, "stable@stable"@dpdk.org To: yliu@fridaylinux.org Return-path: In-Reply-To: <20170920091917.3929-1-danielx.t.mrzyglod@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The unscrutinized value may be incorrectly assumed to be within a certain range by later operations. In vhost_user_read: An unscrutinized value from an untrusted source used in a trusted context - the value of sz_payload may be harmfull and we need limit them to the max value of payload. Coverity issue: 139601 Fixes: 6a84c37e3975 ("net/virtio-user: add vhost-user adapter layer") Cc: jianfeng.tan@intel.com Cc: stable@stable@dpdk.org Signed-off-by: Daniel Mrzyglod --- v2: * Add Cc for stable in gitlog massage * Add Coverity line * v1 was acked by Acked-by: Jianfeng Tan drivers/net/virtio/virtio_user/vhost_user.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/virtio/virtio_user/vhost_user.c b/drivers/net/virtio/virtio_user/vhost_user.c index 4ad7b21..b490336 100644 --- a/drivers/net/virtio/virtio_user/vhost_user.c +++ b/drivers/net/virtio/virtio_user/vhost_user.c @@ -130,6 +130,10 @@ vhost_user_read(int fd, struct vhost_user_msg *msg) } sz_payload = msg->size; + + if (sz_payload > sizeof(msg->payload)) + goto fail; + if (sz_payload) { ret = recv(fd, (void *)((char *)msg + sz_hdr), sz_payload, 0); if (ret < sz_payload) { -- 2.7.4