From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH 10/12] vhost: support to kick in secondary process Date: Thu, 21 Sep 2017 11:33:25 +0800 Message-ID: <20170921033323.GA2251@yliu-home> References: <1503654052-84730-1-git-send-email-jianfeng.tan@intel.com> <1503654052-84730-11-git-send-email-jianfeng.tan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, bruce.richardson@intel.com, konstantin.ananyev@intel.com, pablo.de.lara.guarch@intel.com, thomas@monjalon.net, maxime.coquelin@redhat.com, mtetsuyah@gmail.com, ferruh.yigit@intel.com To: Jianfeng Tan Return-path: Received: from mail-pf0-f177.google.com (mail-pf0-f177.google.com [209.85.192.177]) by dpdk.org (Postfix) with ESMTP id 7AD5A6D45 for ; Thu, 21 Sep 2017 05:33:37 +0200 (CEST) Received: by mail-pf0-f177.google.com with SMTP id d187so2562607pfg.11 for ; Wed, 20 Sep 2017 20:33:37 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1503654052-84730-11-git-send-email-jianfeng.tan@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Firstly, very sorry for so late review! On Fri, Aug 25, 2017 at 09:40:50AM +0000, Jianfeng Tan wrote: > To support kick in secondary process, we propose callfd_pri and > kickfd_pri to store the value in primary process; and by a new > API, rte_vhost_set_vring_effective_fd(), we can set effective > callfd and kickfd which can be used by secondary process. > > Note in this case, either primary process or the secondary process > can kick the frontend; that is, they cannot kick a vring at the > same time. Since only one can work, why not just overwriting the fd? Say, you could introudce some APIs like "rte_vhost_set_vring_callfd", then you don't need to introduce few more fields like "callfd_pri". --yliu