From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH v3 0/4] eventdev: cover letter: ethernet Rx
 queue event adapter
Date: Thu, 21 Sep 2017 18:06:04 +0530
Message-ID: <20170921123603.GB20126@jerin>
References: <1505219369-2493-1-git-send-email-nikhil.rao@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: bruce.richardson@intel.com, gage.eads@intel.com, dev@dpdk.org,
 thomas@monjalon.net, harry.van.haaren@intel.com,
 hemant.agrawal@nxp.com, nipun.gupta@nxp.com,
 narender.vangati@intel.com, erik.g.carrillo@intel.com,
 abhinandan.gujjar@intel.com
To: Nikhil Rao <nikhil.rao@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-CY1-obe.outbound.protection.outlook.com
 (mail-cys01nam02on0081.outbound.protection.outlook.com [104.47.37.81])
 by dpdk.org (Postfix) with ESMTP id 2ECE31B1A3
 for <dev@dpdk.org>; Thu, 21 Sep 2017 14:36:29 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1505219369-2493-1-git-send-email-nikhil.rao@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Tue, 12 Sep 2017 17:59:25 +0530
> From: Nikhil Rao <nikhil.rao@intel.com>
> To: jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com
> CC: gage.eads@intel.com, dev@dpdk.org, thomas@monjalon.net,
>  harry.van.haaren@intel.com, hemant.agrawal@nxp.com, nipun.gupta@nxp.com,
>  narender.vangati@intel.com, erik.g.carrillo@intel.com,
>  abhinandan.gujjar@intel.com, Nikhil Rao <nikhil.rao@intel.com>
> Subject: [PATCH v3 0/4] eventdev: cover letter: ethernet Rx queue event
>  adapter
> X-Mailer: git-send-email 2.7.4
> 
> Eventdev-based networking applications require a component to dequeue
> packets from NIC Rx queues and inject them into eventdev queues[1]. While
> some platforms (e.g. Cavium Octeontx) do this operation in hardware, other
> platforms use software.
> 
> This patchset introduces an ethernet Rx event adapter that dequeues packets
> from ethernet devices and enqueues them to event devices. This patch is based on
> a previous RFC[2] and supercedes [3], the main difference being that
> this version implements a common abstraction for HW and SW based packet transfers.
> 
> The adapter is designed to work with the EAL service core[4] for SW based
> packet transfers. An eventdev PMD callback is used to determine that SW
> based packet transfer service is required. The application can discover
> and configure the service with a core mask using rte_service APIs.
> 
> The adapter can service multiple ethernet devices and queues. For SW based
> packet transfers each queue is  configured with a servicing weight to
> control the relative frequency with which the adapter polls the queue,
> and the event fields to use when constructing packet events. The adapter
> has two modes for programming an event's flow ID: use a static per-queue
> user-specified value or use the RSS hash.
> 
> A detailed description of the adapter is contained in the header's
> comments.

Hi Nikhil.

Overall this series looks good. The patch specific comments, I will send
on each patches.

Please fix the
1) ./devtools/check-git-log.sh & ./devtools/checkpatches.sh issues with
series
2) I guess for next revision you could split the patches to more fine
granularity with make sure each patch build separately.