From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Viktorin <viktorin@rehivetech.com>
Subject: Re: [PATCH] librte_eal: fix wrong assert for arm and ppc
Date: Thu, 21 Sep 2017 17:18:50 +0200
Message-ID: <20170921171850.65238057.viktorin@rehivetech.com>
References: <20170921130404.4978-1-lma@semihalf.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: chaozhu@linux.vnet.ibm.com, dev@dpdk.org
To: Lukasz Majczak <lma@semihalf.com>
Return-path: <dev-bounces@dpdk.org>
Received: from wes1-so1.wedos.net (wes1-so1-b.wedos.net [46.28.106.43])
 by dpdk.org (Postfix) with ESMTP id 963CF199AF
 for <dev@dpdk.org>; Thu, 21 Sep 2017 17:18:54 +0200 (CEST)
In-Reply-To: <20170921130404.4978-1-lma@semihalf.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 21 Sep 2017 15:04:04 +0200
Lukasz Majczak <lma@semihalf.com> wrote:

> The assertion of return value from the open() function is done against
> 0, while it is a correct value - open() returns -1 in case of an error.
> It causes problems while trying to run as a daemon, in which case, this
> call to open() will return 0 as a valid descriptor.

Good catch! Please add also:

Fixes: b94e5c9406b5 ("eal/arm: add CPU flags for ARMv7")
Fixes: 97523f822ba9 ("eal/arm: add CPU flags for ARMv8")
Fixes: 9ae155385686 ("eal/ppc: cpu flag checks for IBM Power")

> 
> Signed-off-by: Lukasz Majczak <lma@semihalf.com>

Acked-by: Jan Viktorin <viktorin@rehivetech.com>