From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yliu@fridaylinux.org>
Subject: Re: [PATCH v2 12/12] net/vhost: support to run in the
 secondary process
Date: Sat, 30 Sep 2017 19:34:47 +0800
Message-ID: <20170930113447.GF6251@yliu-home>
References: <1503654052-84730-1-git-send-email-jianfeng.tan@intel.com>
 <1506606959-76230-1-git-send-email-jianfeng.tan@intel.com>
 <1506606959-76230-13-git-send-email-jianfeng.tan@intel.com>
 <20170930082319.GD6251@yliu-home>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, bruce.richardson@intel.com, konstantin.ananyev@intel.com,
 pablo.de.lara.guarch@intel.com, thomas@monjalon.net,
 maxime.coquelin@redhat.com, mtetsuyah@gmail.com, ferruh.yigit@intel.com
To: Jianfeng Tan <jianfeng.tan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com
 [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 4D8193257
 for <dev@dpdk.org>; Sat, 30 Sep 2017 13:35:06 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20170930082319.GD6251@yliu-home>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


On Thu, Sep 30, 2017 at 12:53:00PM +0000, Jianfeng Tan wrote:
>On 9/30/2017 4:23 PM, Yuanhan Liu wrote:
> > On Thu, Sep 28, 2017 at 01:55:59PM +0000, Jianfeng Tan wrote:
> >> +static int
> >>   new_device(int vid)
> >>   {
> >>   	struct rte_eth_dev *eth_dev;
> >> @@ -610,6 +685,8 @@ new_device(int vid)
> >>   	_rte_eth_dev_callback_process(eth_dev, RTE_ETH_EVENT_INTR_LSC,
> >>   				      NULL, NULL);
> >>   
> >> +	share_device(vid);
> >> +
> > Another question is, have you considered/tested the case when the VM
> > changes the qeueue number later?
> 
> Yes, that is a covered test case, we use ethtool to increase the 
> combined queue number; see cover letter for detail.

Sorry I missed that!

However, I'm not quite sure I understood you:

    Step 5: enable multi queue in VM1 and VM2.
      $ ethtool -L ethX combined 2
    
    Note in this test case, only queue 1, i.e., secondary process can process
    packets. To use queue 1, basically, we can run command like:
      $ taskset -c 1 <commands>

Do you mean the secondary can't rx/tx pkts from/to the 2nd queue?
And you are asking the user to add "taskset -c 1" each time he
wants to run a command inside the VM?

	--yliu