From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH v2] examples/l3fwd: pass flow arguments when start app Date: Sun, 1 Oct 2017 10:24:10 -0700 Message-ID: <20171001102410.3c928ad5@xeon-e3> References: <1506565888-194214-1-git-send-email-xiaoyun.li@intel.com> <1506736748-50515-1-git-send-email-xiaoyun.li@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: jingjing.wu@intel.com, dev@dpdk.org To: Xiaoyun Li Return-path: Received: from mail-pf0-f173.google.com (mail-pf0-f173.google.com [209.85.192.173]) by dpdk.org (Postfix) with ESMTP id EF03E532E for ; Sun, 1 Oct 2017 19:24:12 +0200 (CEST) Received: by mail-pf0-f173.google.com with SMTP id b70so1880215pfl.8 for ; Sun, 01 Oct 2017 10:24:12 -0700 (PDT) In-Reply-To: <1506736748-50515-1-git-send-email-xiaoyun.li@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, 30 Sep 2017 09:59:08 +0800 Xiaoyun Li wrote: > To make the performance can be tuning on different NICs or platforms. We > need to make the number of descriptors and Rx/TX threshold as arguments > when starting l3fwd application. > > Signed-off-by: Xiaoyun Li Not sure about this. The point of l3fwd is to make it as simple an application as possible to help users. Given that drivers can now supply default values for thresholds, I think the l3fwd sample should get rid of all the special descriptor values it is setting. Then if the values are not right for best performance that should be pushed back to the driver writer to fix.