From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomasz Duszynski <tdu@semihalf.com>
Subject: Re: [PATCH v2 2/4] doc: add mrvl crypto pmd documentation
Date: Fri, 6 Oct 2017 10:06:20 +0200
Message-ID: <20171006080620.GD11828@tdu>
References: <1506418805-12117-1-git-send-email-tdu@semihalf.com>
 <1506594212-15803-1-git-send-email-tdu@semihalf.com>
 <1506594212-15803-3-git-send-email-tdu@semihalf.com>
 <E115CCD9D858EF4F90C690B0DCB4D8976CC2BE15@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: Tomasz Duszynski <tdu@semihalf.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "mw@semihalf.com" <mw@semihalf.com>, "dima@marvell.com" <dima@marvell.com>,
 "nsamsono@marvell.com" <nsamsono@marvell.com>,
 "Jianbo.liu@linaro.org" <Jianbo.liu@linaro.org>,
 Jacek Siuda <jck@semihalf.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lf0-f51.google.com (mail-lf0-f51.google.com
 [209.85.215.51]) by dpdk.org (Postfix) with ESMTP id 62ECF1B225
 for <dev@dpdk.org>; Fri,  6 Oct 2017 10:06:22 +0200 (CEST)
Received: by mail-lf0-f51.google.com with SMTP id 90so11302199lfs.13
 for <dev@dpdk.org>; Fri, 06 Oct 2017 01:06:22 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CC2BE15@IRSMSX108.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Oct 05, 2017 at 02:45:33PM +0000, De Lara Guarch, Pablo wrote:
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Duszynski
> > Sent: Thursday, September 28, 2017 11:24 AM
> > To: dev@dpdk.org
> > Cc: mw@semihalf.com; dima@marvell.com; nsamsono@marvell.com;
> > Jianbo.liu@linaro.org; Tomasz Duszynski <tdu@semihalf.com>; Jacek Siuda
> > <jck@semihalf.com>
> > Subject: [dpdk-dev] [PATCH v2 2/4] doc: add mrvl crypto pmd
> > documentation
> >
> > Add documentation for the MRVL CRYPTO PMD driver.
>
> You should add the pmd in the list of device types (devtype),
> In doc/guides/tools/cryptoperf.rst.

ACK

>
> Also, you should mention this new PMD in release notes.
>

ACK

> >
> > Signed-off-by: Jacek Siuda <jck@semihalf.com>
> > Signed-off-by: Tomasz Duszynski <jck@semihalf.com>
> > ---
> >  doc/guides/cryptodevs/features/mrvl.ini |  42 +++++++
> >  doc/guides/cryptodevs/index.rst         |   1 +
> >  doc/guides/cryptodevs/mrvl.rst          | 198
>
> ...
>
> > +++ b/doc/guides/cryptodevs/mrvl.rst
> > @@ -0,0 +1,198 @@
>
> ...
>
> > +
> > +   ./l2fwd-crypto -c 0x3 --vdev=3Deth_mrvl,iface=3Deth0
> > + --vdev=3Dcryptodev_mrvl_pmd
>
> I will make the comment also in the first patch, but you should use "cryp=
to_mrvl".
> The cryptodev_*_pmd convention is old and we are only maintaining it for =
backward compatibility.
> So, I would use "crypto_mrvl".

ACK

Thanks for comments.

--
- Tomasz Duszy=C5=84ski