From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro Subject: Re: [PATCH v4 2/5] ethdev: increase port_id range Date: Fri, 6 Oct 2017 16:34:30 +0200 Message-ID: <20171006143429.x3oxhe2247lxf2em@laranjeiro-vm> References: <20170909144727.46388-1-zhiyong.yang@intel.com> <20170921083243.57991-1-zhiyong.yang@intel.com> <20170921083243.57991-3-zhiyong.yang@intel.com> <20170921114928.GC11375@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: Zhiyong Yang , dev@dpdk.org, thomas@monjalon.net, Adrien Mazarguil To: ferruh.yigit@intel.com Return-path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 797A32F42 for ; Fri, 6 Oct 2017 16:34:41 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id u138so8322921wmu.4 for ; Fri, 06 Oct 2017 07:34:41 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20170921114928.GC11375@6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 21, 2017 at 01:49:28PM +0200, Adrien Mazarguil wrote: > On Thu, Sep 21, 2017 at 04:32:40PM +0800, Zhiyong Yang wrote: > > Extend port_id definition from uint8_t to uint16_t in lib and drivers > > data structures, specifically rte_eth_dev_data. Modify the APIs, > > drivers and app using port_id at the same time. > > > > Fix some checkpatch issues from the original code and remove some > > unnecessary cast operations. > > > > release_17_11 and deprecation have been updated in the patch. > > > > Signed-off-by: Zhiyong Yang > > --- > > > diff --git a/drivers/net/mlx5/mlx5_rxtx.h b/drivers/net/mlx5/mlx5_rxtx.h > > index 7de1d1086..238a64f43 100644 > > --- a/drivers/net/mlx5/mlx5_rxtx.h > > +++ b/drivers/net/mlx5/mlx5_rxtx.h > > @@ -112,14 +112,14 @@ struct rxq { > > unsigned int sges_n:2; /* Log 2 of SGEs (max buffers per packet). */ > > unsigned int cqe_n:4; /* Log 2 of CQ elements. */ > > unsigned int elts_n:4; /* Log 2 of Mbufs. */ > > - unsigned int port_id:8; > > unsigned int rss_hash:1; /* RSS hash result is enabled. */ > > unsigned int mark:1; /* Marked flow available on the queue. */ > > unsigned int pending_err:1; /* CQE error needs to be handled. */ > > unsigned int trim_elts:1; /* Whether elts needs clean-up. */ > > - unsigned int :6; /* Remaining bits. */ > > + unsigned int :14; /* Remaining bits. */ > > volatile uint32_t *rq_db; > > volatile uint32_t *cq_db; > > + uint16_t port_id; > > uint16_t rq_ci; > > uint16_t rq_pi; > > uint16_t cq_ci; > > > Can't speak for the other PMDs, but it looks OK as far as mlx4/mlx5 are > affected. This is my ack for this specific change: > > Acked-by: Adrien Mazarguil > > -- > Adrien Mazarguil > 6WIND Ferruh, the patch applied on master-net does not match this version of mlx5_rxtx.h causing a performance issue. Regards, -- Nélio Laranjeiro 6WIND