From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yongseok Koh <yskoh@mellanox.com>
Subject: Re: [PATCH v2 28/30] net/mlx5: handle RSS hash
 configuration in RSS flow
Date: Fri, 6 Oct 2017 10:30:14 -0700
Message-ID: <20171006173013.GA19913@yongseok-MBP.local>
References: <cover.1501681927.git.nelio.laranjeiro@6wind.com>
 <cover.1507207731.git.nelio.laranjeiro@6wind.com>
 <8f61b0656eab8f398c065b72f2496dc785fde0f8.1507207731.git.nelio.laranjeiro@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, adrien.mazarguil@6wind.com, ferruh.yigit@intel.com
To: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from EUR01-VE1-obe.outbound.protection.outlook.com
 (mail-ve1eur01on0076.outbound.protection.outlook.com [104.47.1.76])
 by dpdk.org (Postfix) with ESMTP id A7C331B1FB
 for <dev@dpdk.org>; Fri,  6 Oct 2017 19:30:29 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <8f61b0656eab8f398c065b72f2496dc785fde0f8.1507207731.git.nelio.laranjeiro@6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Oct 05, 2017 at 02:50:00PM +0200, Nelio Laranjeiro wrote:
> Add RSS support according to the RSS configuration.
> 
> A special case is handled, when the pattern does not cover the RSS hash
> configuration request such as:
> 
>  flow create 0 ingress pattern eth / end actions rss queues 0 1 end / end
> 
> In such situation with the default configuration of testpmd RSS i.e. IP,
> it should be converted to 3 Verbs flow to handle correctly the request:
> 
>  1. IPv4 flow, an extra IPv4 wildcard specification needs to be added in
>     the conversion.
>  2. IPv6 flow, same as for IPv4.
>  3. Ethernet followed by any other protocol on which no RSS can be
>     performed and thus the traffic will be redirected to the first queue of
>     the user request.
> 
> The same kind of issue is handled if the RSS is performed only on UDPv4 or
> UDPv6 or TCPv*.
> 
> This does not handle a priority conflict which can occurs if the user adds
> several colliding flow rules.  Currently in the example above, the request
> is already consuming 2 priorities (1 for IPv4/IPV6 matching rule priority
> and one for Ethernet matching rule priority + 1).
> 
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> ---
Acked-by: Yongseok Koh <yskoh@mellanox.com>
 
Thanks