From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomasz Duszynski <tdu@semihalf.com>
Subject: Re: [PATCH v3 1/4] crypto/mrvl: add mrvl crypto pmd
	driver
Date: Tue, 10 Oct 2017 12:25:22 +0200
Message-ID: <20171010102522.GA6236@tdu>
References: <1506594212-15803-1-git-send-email-tdu@semihalf.com>
 <1507408106-11292-1-git-send-email-tdu@semihalf.com>
 <1507408106-11292-2-git-send-email-tdu@semihalf.com>
 <E115CCD9D858EF4F90C690B0DCB4D8976CC2EF80@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: Tomasz Duszynski <tdu@semihalf.com>, "dev@dpdk.org" <dev@dpdk.org>,
 "mw@semihalf.com" <mw@semihalf.com>, "dima@marvell.com" <dima@marvell.com>,
 "nsamsono@marvell.com" <nsamsono@marvell.com>,
 "Jianbo.liu@linaro.org" <Jianbo.liu@linaro.org>,
 Jacek Siuda <jck@semihalf.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lf0-f43.google.com (mail-lf0-f43.google.com
 [209.85.215.43]) by dpdk.org (Postfix) with ESMTP id 17F111B214
 for <dev@dpdk.org>; Tue, 10 Oct 2017 12:25:24 +0200 (CEST)
Received: by mail-lf0-f43.google.com with SMTP id a16so12993842lfk.0
 for <dev@dpdk.org>; Tue, 10 Oct 2017 03:25:23 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CC2EF80@IRSMSX108.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Oct 10, 2017 at 10:16:42AM +0000, De Lara Guarch, Pablo wrote:
>
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tomasz Duszynski
> > Sent: Saturday, October 7, 2017 9:28 PM
> > To: dev@dpdk.org
> > Cc: mw@semihalf.com; dima@marvell.com; nsamsono@marvell.com;
> > Jianbo.liu@linaro.org; Tomasz Duszynski <tdu@semihalf.com>; Jacek Siuda
> > <jck@semihalf.com>
> > Subject: [dpdk-dev] [PATCH v3 1/4] crypto/mrvl: add mrvl crypto pmd
> > driver
>
> ...
>
> > diff --git a/drivers/crypto/mrvl/rte_mrvl_pmd.c
> > b/drivers/crypto/mrvl/rte_mrvl_pmd.c
> > new file mode 100644
> > index 0000000..a404bf4
> > --- /dev/null
> > +++ b/drivers/crypto/mrvl/rte_mrvl_pmd.c
>
> ...
>
> > +
> > +/* Register the driver in constructor. */
> > +RTE_PMD_REGISTER_VDEV(CRYPTODEV_NAME_MRVL_PMD,
> > cryptodev_mrvl_pmd_drv);
> > +RTE_PMD_REGISTER_PARAM_STRING(CRYPTODEV_NAME_MRVL_PMD,
> > +	"max_nb_queue_pairs=3D<int> "
> > +	"max_nb_sessions=3D<int> "
> > +	"socket_id=3D<int>");
> > +RTE_PMD_REGISTER_CRYPTO_DRIVER(cryptodev_mrvl_pmd_drv,
> > cryptodev_driver_id);
>
> This macro now needs 3 parameters. You probably rebased the patchset
> against the main repo, and not dpdk-next-crypto.

ACK

> Just a reminder that all crypto patches should target this repository.
>
> Apart from this, the rest of the patchset looks good to me.
> So send a v4 and hopefully it can be merged in RC1.
>
> Pablo
>

--
- Tomasz Duszy=C5=84ski