From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH v6 3/7] eventdev: add eth Rx adapter caps
 function to SW PMD
Date: Wed, 11 Oct 2017 08:27:20 +0530
Message-ID: <20171011025719.GA1933@jerin>
References: <1507674097-19597-1-git-send-email-nikhil.rao@intel.com>
 <1507674097-19597-4-git-send-email-nikhil.rao@intel.com>
 <1760785.loeYggim5W@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Nikhil Rao <nikhil.rao@intel.com>, dev@dpdk.org, bruce.richardson@intel.com
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-SN1-obe.outbound.protection.outlook.com
 (mail-sn1nam02on0089.outbound.protection.outlook.com [104.47.36.89])
 by dpdk.org (Postfix) with ESMTP id C76761B1E6
 for <dev@dpdk.org>; Wed, 11 Oct 2017 04:57:40 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1760785.loeYggim5W@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Wed, 11 Oct 2017 01:16:25 +0200
> From: Thomas Monjalon <thomas@monjalon.net>
> To: Nikhil Rao <nikhil.rao@intel.com>
> Cc: dev@dpdk.org, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com
> Subject: Re: [dpdk-dev] [PATCH v6 3/7] eventdev: add eth Rx adapter caps
>  function to SW PMD
> 
> Hi,
> 
> 11/10/2017 00:21, Nikhil Rao:
> > --- a/lib/librte_eventdev/rte_eventdev_pmd.h
> > +++ b/lib/librte_eventdev/rte_eventdev_pmd.h
> > @@ -83,6 +83,14 @@ extern "C" {
> >         } \
> >  } while (0)
> >  
> > +#define RTE_EVENT_ETH_RX_ADAPTER_SW_CAP \
> > +               ((RTE_EVENT_ETH_RX_ADAPTER_CAP_OVERRIDE_FLOW_ID) | \
> > +                       (RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ))
> > +
> > +/**< Ethernet Rx adapter cap to return If the packet transfers from
> > + * the ethdev to eventdev use a SW service function
> > + */
> 
> It is a value specific to the SW driver.
> I think it should not be defined in librte_eventdev.

It should be defined in librte_eventdev as HW drivers use this flag
if HW adapter needs to use SW for fallback.

Already discussed this at
http://dpdk.org/ml/archives/dev/2017-September/075302.html

See HW driver usage as example for dpaa2.
http://dpdk.org/ml/archives/dev/2017-October/078391.html
function: dpaa2_eventdev_eth_caps_get

> 
> Do you mind to move it for RC2?