From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomasz Duszynski <tdu@semihalf.com>
Subject: Re: [PATCH] crypto: use snprintf return value correctly
Date: Wed, 11 Oct 2017 12:42:15 +0200
Message-ID: <20171011104215.GA14608@tdu>
References: <1507713940-12268-1-git-send-email-tdu@semihalf.com>
 <20171011095800.GA43968@bricha3-MOBL3.ger.corp.intel.com>
 <E115CCD9D858EF4F90C690B0DCB4D8976CC2FF8F@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>,
 Tomasz Duszynski <tdu@semihalf.com>, "dev@dpdk.org" <dev@dpdk.org>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lf0-f49.google.com (mail-lf0-f49.google.com
 [209.85.215.49]) by dpdk.org (Postfix) with ESMTP id 9E0B31B1B1
 for <dev@dpdk.org>; Wed, 11 Oct 2017 12:42:17 +0200 (CEST)
Received: by mail-lf0-f49.google.com with SMTP id g70so1566702lfl.3
 for <dev@dpdk.org>; Wed, 11 Oct 2017 03:42:17 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CC2FF8F@IRSMSX108.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Oct 11, 2017 at 10:09:02AM +0000, De Lara Guarch, Pablo wrote:
> Hi,
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson
> > Sent: Wednesday, October 11, 2017 10:58 AM
> > To: Tomasz Duszynski <tdu@semihalf.com>
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] crypto: use snprintf return value corre=
ctly
> >
> > On Wed, Oct 11, 2017 at 11:25:40AM +0200, Tomasz Duszynski wrote:
> > > snprintf return value is the length of was encoded into destination
> > > array excluding '\0'. Thus return value equal to the length of the
> > > destination array or more means truncation.
> > >
> > > This commit fixes improper use of the return value.
> > >
> > > Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
> > > ---
> > Good catch.
> >
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Since this is a fix, you should add Fixes lines (one per PMD), and CC sta=
ble.
>
> Thanks!
> Pablo
>

ACK

--
- Tomasz Duszy=C5=84ski