From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Mrzyglod Subject: [PATCH v3] eal: fix resource leak Date: Wed, 11 Oct 2017 13:53:53 +0200 Message-ID: <20171011115353.40043-1-danielx.t.mrzyglod@intel.com> References: <20170922144820.16590-1-danielx.t.mrzyglod@intel.com> Cc: dev@dpdk.org, Daniel Mrzyglod , stable@dpdk.org To: thomas@monjalon.net Return-path: In-Reply-To: <20170922144820.16590-1-danielx.t.mrzyglod@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Memory allocated in strdup is not free. Coverity issue: 143257 Fixes: d8a2bc71dfc2 ("log: remove app path from syslog id") Cc: thomas@monjalon.net Cc: stable@dpdk.org Signed-off-by: Daniel Mrzyglod --- v3: * remove strdup because it's basically striped argv[0] v2: * Fix due to compilation errors lib/librte_eal/linuxapp/eal/eal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index 1f07347..739b61a 100644 --- a/lib/librte_eal/linuxapp/eal/eal.c +++ b/lib/librte_eal/linuxapp/eal/eal.c @@ -763,7 +763,7 @@ rte_eal_init(int argc, char **argv) } logid = strrchr(argv[0], '/'); - logid = strdup(logid ? logid + 1: argv[0]); + logid = logid ? logid + 1 : argv[0]; thread_id = pthread_self(); -- 2.7.4