From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomasz Duszynski <tdu@semihalf.com>
Subject: Re: [PATCH v4 02/16] net/mrvl: add mrvl net pmd driver
 skeleton
Date: Thu, 12 Oct 2017 08:51:04 +0200
Message-ID: <20171012065104.GC19106@tdu>
References: <1507031500-11473-1-git-send-email-tdu@semihalf.com>
 <1507561244-20115-1-git-send-email-tdu@semihalf.com>
 <1507561244-20115-3-git-send-email-tdu@semihalf.com>
 <9041127.34t6OW5FrT@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: Tomasz Duszynski <tdu@semihalf.com>, dev@dpdk.org, mw@semihalf.com,
 dima@marvell.com, nsamsono@marvell.com, Jianbo.liu@linaro.org,
 Jacek Siuda <jck@semihalf.com>
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lf0-f46.google.com (mail-lf0-f46.google.com
 [209.85.215.46]) by dpdk.org (Postfix) with ESMTP id 4AF67201
 for <dev@dpdk.org>; Thu, 12 Oct 2017 08:51:05 +0200 (CEST)
Received: by mail-lf0-f46.google.com with SMTP id r129so4819148lff.8
 for <dev@dpdk.org>; Wed, 11 Oct 2017 23:51:05 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <9041127.34t6OW5FrT@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Oct 11, 2017 at 03:38:36PM +0200, Thomas Monjalon wrote:
> Hi,
>
> 09/10/2017 17:00, Tomasz Duszynski:
> >  #
> > +# Compile Marvell PMD driver
> > +#
> > +CONFIG_RTE_LIBRTE_MRVL_PMD=3Dn
> > +CONFIG_RTE_LIBRTE_MRVL_DEBUG=3Dn
> > +CONFIG_RTE_MRVL_MUSDK_DMA_MEMSIZE=3D41943040
>
> We are trying to remove build-time configurations and behave like
> a true library.
>
> The DEBUG config options are now prohibited.
> Where is it used in your code?
> If it is used for logs, you should switch to the dynamic log config.
>
> What is MUSDK_DMA_MEMSIZE?
> If the value cannot change, it must be a constant in the code.
> If it can change, it should be a run-time driver option.

It's up to the user what MUSDK_DMA_MEMSIZE is going to be. Currently it's
set to value that should work it all cases.

Except that, MUSDK_DMA_MEMSIZE is used as synchronization point for net
and crypto (on condition they are used together i.e ipsec-secgw).

Suppose we have two different MUSDK_DMA_MEMSIZE defined for net/crypto then
dma memsize allocated will depend on driver probing sequence which might
confuse user.

If you have any better idea please share it with us. Thanks.

>
> Thank you and welcome

--
- Tomasz Duszy=C5=84ski