From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet Subject: Re: [PATCH v5 20/20] bus: rename scan policy as probe policy Date: Thu, 12 Oct 2017 12:55:46 +0200 Message-ID: <20171012105546.GB3408@bidouze.vm.6wind.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit To: dev@dpdk.org Return-path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id 4E4171B208 for ; Thu, 12 Oct 2017 12:55:59 +0200 (CEST) Received: by mail-wm0-f54.google.com with SMTP id u138so12260400wmu.4 for ; Thu, 12 Oct 2017 03:55:59 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id r63sm20301455wmg.13.2017.10.12.03.55.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Oct 2017 03:55:57 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch is not part of this series, sorry. I can send a v6 if necessary, but here simply ignore this patch. On Thu, Oct 12, 2017 at 12:45:47PM +0200, Gaetan Rivet wrote: > This bus configuration item is misnamed, as it actually refers to the > probing process. > > Signed-off-by: Gaetan Rivet > --- > drivers/bus/pci/pci_common.c | 2 +- > lib/librte_eal/common/eal_common_devargs.c | 6 +++--- > lib/librte_eal/common/include/rte_bus.h | 12 ++++++------ > 3 files changed, 10 insertions(+), 10 deletions(-) > > diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c > index d7a1c05..cc23a39 100644 > --- a/drivers/bus/pci/pci_common.c > +++ b/drivers/bus/pci/pci_common.c > @@ -373,7 +373,7 @@ rte_pci_probe(void) > int probe_all = 0; > int ret = 0; > > - if (rte_pci_bus.bus.conf.scan_mode != RTE_BUS_SCAN_WHITELIST) > + if (rte_pci_bus.bus.conf.probe_mode != RTE_BUS_PROBE_WHITELIST) > probe_all = 1; > > FOREACH_DEVICE_ON_PCIBUS(dev) { > diff --git a/lib/librte_eal/common/eal_common_devargs.c b/lib/librte_eal/common/eal_common_devargs.c > index 6ac88d6..f5ef913 100644 > --- a/lib/librte_eal/common/eal_common_devargs.c > +++ b/lib/librte_eal/common/eal_common_devargs.c > @@ -170,11 +170,11 @@ rte_eal_devargs_add(enum rte_devtype devtype, const char *devargs_str) > bus = devargs->bus; > if (devargs->type == RTE_DEVTYPE_BLACKLISTED_PCI) > devargs->policy = RTE_DEV_BLACKLISTED; > - if (bus->conf.scan_mode == RTE_BUS_SCAN_UNDEFINED) { > + if (bus->conf.probe_mode == RTE_BUS_PROBE_UNDEFINED) { > if (devargs->policy == RTE_DEV_WHITELISTED) > - bus->conf.scan_mode = RTE_BUS_SCAN_WHITELIST; > + bus->conf.probe_mode = RTE_BUS_PROBE_WHITELIST; > else if (devargs->policy == RTE_DEV_BLACKLISTED) > - bus->conf.scan_mode = RTE_BUS_SCAN_BLACKLIST; > + bus->conf.probe_mode = RTE_BUS_PROBE_BLACKLIST; > } > TAILQ_INSERT_TAIL(&devargs_list, devargs, next); > return 0; > diff --git a/lib/librte_eal/common/include/rte_bus.h b/lib/librte_eal/common/include/rte_bus.h > index 6fb0834..331d954 100644 > --- a/lib/librte_eal/common/include/rte_bus.h > +++ b/lib/librte_eal/common/include/rte_bus.h > @@ -168,19 +168,19 @@ typedef int (*rte_bus_unplug_t)(struct rte_device *dev); > typedef int (*rte_bus_parse_t)(const char *name, void *addr); > > /** > - * Bus scan policies > + * Bus probe policies > */ > -enum rte_bus_scan_mode { > - RTE_BUS_SCAN_UNDEFINED, > - RTE_BUS_SCAN_WHITELIST, > - RTE_BUS_SCAN_BLACKLIST, > +enum rte_bus_probe_mode { > + RTE_BUS_PROBE_UNDEFINED, > + RTE_BUS_PROBE_WHITELIST, > + RTE_BUS_PROBE_BLACKLIST, > }; > > /** > * A structure used to configure bus operations. > */ > struct rte_bus_conf { > - enum rte_bus_scan_mode scan_mode; /**< Scan policy. */ > + enum rte_bus_probe_mode probe_mode; /**< Probe policy. */ > }; > > > -- > 2.1.4 > -- Gaëtan Rivet 6WIND