From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH 4/4] eal/x86: implement arch-specific TSC
 freq query
Date: Fri, 13 Oct 2017 16:17:49 +0100
Message-ID: <20171013151749.GA54072@bricha3-MOBL3.ger.corp.intel.com>
References: <cover.1506058385.git.gowrishankar.m@linux.vnet.ibm.com>
 <20171013000247.4158-5-thomas@monjalon.net>
 <20171012204724.120d7b25@xeon-e3> <1683017.mmorKbpdtt@xps>
 <20171013081306.15b4a494@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Thomas Monjalon <thomas@monjalon.net>,
 gowrishankar.m@linux.vnet.ibm.com, jerin.jacob@caviumnetworks.com,
 jianbo.liu@linaro.org, sergio.gonzalez.monroy@intel.com, dev@dpdk.org
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id 71BDF1B74E
 for <dev@dpdk.org>; Fri, 13 Oct 2017 17:17:56 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20171013081306.15b4a494@xeon-e3>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Oct 13, 2017 at 08:13:06AM -0700, Stephen Hemminger wrote:
> On Fri, 13 Oct 2017 09:30:43 +0200
> Thomas Monjalon <thomas@monjalon.net> wrote:
> 
> > 13/10/2017 05:47, Stephen Hemminger:
> > > On Fri, 13 Oct 2017 02:02:47 +0200
> > > Thomas Monjalon <thomas@monjalon.net> wrote:
> > >   
> > > > +static uint32_t
> > > > +check_model_wsm_nhm(uint8_t model)
> > > > +{
> > > > +	switch (model) {
> > > > +	/* Westmere */
> > > > +	case 0x25:
> > > > +	case 0x2C:
> > > > +	case 0x2F:
> > > > +	/* Nehalem */
> > > > +	case 0x1E:
> > > > +	case 0x1F:
> > > > +	case 0x1A:
> > > > +	case 0x2E:
> > > > +		return 1;
> > > > +	}
> > > > +
> > > > +	return 0;
> > > > +}  
> > > 
> > > How about a table rather than switch?
> > > Also bool rather than int?  
> > 
> > It is a matter of taste :)
> > I plan to push it as is. It can be changed later if desired.
> 
> Also using #define's rather than magic constants would help.

Assuming that we could just come up with more meaningful names that help
more than just have a comment indicating what uarch's each set of
numbers is for. :-)
For me, I don't think #defines are needed to enhance readability here.