From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro Subject: Re: [PATCH v2] doc: update mlx5 flow count limitations Date: Mon, 16 Oct 2017 13:17:42 +0200 Message-ID: <20171016111742.qcb2u7omvomfscgc@laranjeiro-vm> References: <1508142759-24829-1-git-send-email-orika@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: adrien.mazarguil@6wind.com, yskoh@mellanox.com, dev@dpdk.org To: Ori Kam Return-path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id 68A0D1B612 for ; Mon, 16 Oct 2017 13:17:49 +0200 (CEST) Received: by mail-wm0-f43.google.com with SMTP id i124so2042754wmf.3 for ; Mon, 16 Oct 2017 04:17:49 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1508142759-24829-1-git-send-email-orika@mellanox.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 16, 2017 at 11:32:39AM +0300, Ori Kam wrote: > Signed-off-by: Ori Kam > Acked-by: Shahaf Shuler > --- > doc/guides/nics/mlx5.rst | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst > index d24941a..7da5c87 100644 > --- a/doc/guides/nics/mlx5.rst > +++ b/doc/guides/nics/mlx5.rst > @@ -104,7 +104,8 @@ Limitations > ----------- > > - Inner RSS for VXLAN frames is not supported yet. > -- Port statistics through software counters only. > +- Port statistics through software counters only. Flow statistics are > + supported by hardware counters. > - Hardware checksum RX offloads for VXLAN inner header are not supported yet. > - Forked secondary process not supported. > - Flow pattern without any specific vlan will match for vlan packets as well: > @@ -127,6 +128,8 @@ Limitations > - A multi segment packet must have less than 6 segments in case the Tx burst function > is set to multi-packet send or Enhanced multi-packet send. Otherwise it must have > less than 50 segments. > +- Count action for RTE flow is only supported in OFED 4.2. > +- Two identical rules with count action are not supported. This last line does not bring anything, having two identical rules already create a collision which is not defined by the flow API. In PMD situation is is even worse, as it will match both rules and thus it will duplicate a packet. There is no need to add a limit on an undefined behavior by the API itself. Thanks, PS: when you send a new revision, please use the --thread and --in-reply-to to link it with the previous one. -- Nélio Laranjeiro 6WIND