From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerin Jacob Subject: Re: [PATCH] event/sw: fix get of single xstat value Date: Mon, 16 Oct 2017 17:33:45 +0530 Message-ID: <20171016120344.GA30329@jerin> References: <1507650477-74678-1-git-send-email-harry.van.haaren@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, bruce.richardson@intel.com To: Harry van Haaren Return-path: Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0073.outbound.protection.outlook.com [104.47.34.73]) by dpdk.org (Postfix) with ESMTP id 645451B1B8 for ; Mon, 16 Oct 2017 14:04:03 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1507650477-74678-1-git-send-email-harry.van.haaren@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" -----Original Message----- > Date: Tue, 10 Oct 2017 16:47:57 +0100 > From: Harry van Haaren > To: dev@dpdk.org > CC: jerin.jacob@caviumnetworks.com, Harry van Haaren > , bruce.richardson@intel.com > Subject: [PATCH] event/sw: fix get of single xstat value > X-Mailer: git-send-email 2.7.4 > > This commit allows the xstats_get() API to return just a single > value based on its ID. Previously, the "ret_n_lt_stats" value > set to 1 ensured a check to take place that the array was larger > than the available xstats. > > The xstats_get() API allows retriving of individual stats - hence > this check should be removed - by setting "ret_n_lt_stats" to zero. > > Fixes: c1ad03df7ad5 ("event/sw: support xstats") > Cc: bruce.richardson@intel.com > > Signed-off-by: Harry van Haaren Applied to dpdk-next-eventdev/master. Thanks. > --- > drivers/event/sw/sw_evdev_xstats.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/event/sw/sw_evdev_xstats.c b/drivers/event/sw/sw_evdev_xstats.c > index 8cb6d88..61a5c33 100644 > --- a/drivers/event/sw/sw_evdev_xstats.c > +++ b/drivers/event/sw/sw_evdev_xstats.c > @@ -538,7 +538,7 @@ sw_xstats_get(const struct rte_eventdev *dev, > { > struct sw_evdev *sw = sw_pmd_priv(dev); > const uint32_t reset = 0; > - const uint32_t ret_n_lt_stats = 1; > + const uint32_t ret_n_lt_stats = 0; > return sw_xstats_update(sw, mode, queue_port_id, ids, values, n, > reset, ret_n_lt_stats); > } > -- > 2.7.4 >