From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yuanhan Liu Subject: Re: [PATCH v2] vhost: translate addrs in set_vring_addr if ring already enabled Date: Tue, 17 Oct 2017 21:13:54 +0800 Message-ID: <20171017131354.GW1545@yliu-home> References: <20171016142217.19646-1-maxime.coquelin@redhat.com> <20171016145627.19990-1-maxime.coquelin@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: lei.a.yao@intel.com, dev@dpdk.org, jfreiman@redhat.com, thomas@monjalon.net To: Maxime Coquelin Return-path: Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id CADD21B74E for ; Tue, 17 Oct 2017 15:14:00 +0200 (CEST) Content-Disposition: inline In-Reply-To: <20171016145627.19990-1-maxime.coquelin@redhat.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 16, 2017 at 04:56:27PM +0200, Maxime Coquelin wrote: > Commit 3ea7052f4b1b ("vhost: postpone rings addresses translation") > moves rings addresses translation at either vring kick or enable > time, depending on whether protocol features are enabled or not. > This is done not interpret ring information as long as the vring > is not fully initialized. > > The problem is that with old QEMU versions, like v2.5, the ring > is enabled before addresses are sent, so addresses are never > translated. > > This patch fixes the issue by doing the translation in > VHOST_USER_SET_VRING_ADDR handling if ring is already enabled. > > Fixes: 3ea7052f4b1b ("vhost: postpone rings addresses translation") > > Reported-by: Lei Yao > Signed-off-by: Maxime Coquelin > --- > v2: Fixed commit informations (Fixes:, Reported-by:) Applied to dpdk-next-virtio. Thanks. --yliu