From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavan Nikhilesh Bhagavatula Subject: Re: [PATCH 2/3] event/octeontx: add support for event Rx adapter Date: Wed, 18 Oct 2017 13:42:20 +0530 Message-ID: <20171018081219.GA15923@PBHAGAVATULA-LT> References: <1508230393-27018-1-git-send-email-pbhagavatula@caviumnetworks.com> <1508230393-27018-2-git-send-email-pbhagavatula@caviumnetworks.com> <51ebfd06-c9ff-965e-f0ad-b2724f6d76c1@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: "Rao, Nikhil" Return-path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0060.outbound.protection.outlook.com [104.47.38.60]) by dpdk.org (Postfix) with ESMTP id E09BD1B5FE for ; Wed, 18 Oct 2017 10:12:42 +0200 (CEST) Content-Disposition: inline In-Reply-To: <51ebfd06-c9ff-965e-f0ad-b2724f6d76c1@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 17, 2017 at 04:41:44PM +0530, Rao, Nikhil wrote: > > static __rte_always_inline uint16_t > > ssows_get_work(struct ssows *ws, struct rte_event *ev) > > { > >@@ -62,9 +86,10 @@ ssows_get_work(struct ssows *ws, struct rte_event *ev) > > ws->cur_tt = sched_type_queue & 0x3; > > ws->cur_grp = sched_type_queue >> 2; > > sched_type_queue = sched_type_queue << 38; > >- > > ev->event = sched_type_queue | (get_work0 & 0xffffffff); > >- ev->u64 = get_work1; > >+ ev->u64 = get_work1 && !ev->event_type ? > > I think the code readability would be better if you compared event_type to > RTE_EVENT_TYPE_ETHDEV. > Agreed, Will send out a v2. Thanks, Pavan. > Reviewed by: Nikhil Rao