From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet Subject: Re: [PATCH v5 10/20] pci: avoid inlining functions Date: Wed, 18 Oct 2017 10:54:32 +0200 Message-ID: <20171018085432.GC3596@bidouze.vm.6wind.com> References: <35d2cbe2bb9d8c03d0564256a85cce54b8331eee.1507804944.git.gaetan.rivet@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org To: Aaron Conole Return-path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 4E6A31B61B for ; Wed, 18 Oct 2017 10:54:45 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id i124so8479288wmf.3 for ; Wed, 18 Oct 2017 01:54:45 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 17, 2017 at 02:20:45PM -0400, Aaron Conole wrote: > Gaetan Rivet writes: > > > Parsing operations should not happen in performance critical sections. > > Headers should not propose implementations unless duly required. > > > > Signed-off-by: Gaetan Rivet > > --- > > Can these cleanups be done before the move in patch 3? Sure. I wanted to minimize the changes before moving the code. If I had rework to do on these patches, I wanted to avoid having to redo the move and verify the changes were properly propagated. But if it is necessary, these changes can happen before moving the whole lot. -- Gaëtan Rivet 6WIND