From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet Subject: Re: [PATCH] pci: fix check uio bind Date: Thu, 19 Oct 2017 13:42:26 +0200 Message-ID: <20171019114225.GF3596@bidouze.vm.6wind.com> References: <1508411909-63954-1-git-send-email-jianfeng.tan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org, santosh.shukla@caviumnetworks.com, jerin.jacob@caviumnetworks.com, anatoly.burakov@intel.com To: Jianfeng Tan Return-path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id E5B6F1B1F6 for ; Thu, 19 Oct 2017 13:42:38 +0200 (CEST) Received: by mail-wr0-f194.google.com with SMTP id u5so8005837wrc.5 for ; Thu, 19 Oct 2017 04:42:38 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1508411909-63954-1-git-send-email-jianfeng.tan@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Jianfeng, On Thu, Oct 19, 2017 at 11:18:29AM +0000, Jianfeng Tan wrote: > When checking if any devices bound to uio, we did not exclud > those which are blacklisted (or in the case that a whitelist > is specified). > > This patch fixes it by only checking whitelisted devices. > > Fixes: 815c7deaed2d ("pci: get IOMMU class on Linux") > > Signed-off-by: Jianfeng Tan > --- > lib/librte_eal/linuxapp/eal/eal_pci.c | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c > index b4dbf95..2b23d67 100644 > --- a/lib/librte_eal/linuxapp/eal/eal_pci.c > +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c > @@ -516,8 +516,26 @@ static inline int > pci_one_device_bound_uio(void) > { > struct rte_pci_device *dev = NULL; > + struct rte_devargs *devargs; > + int check_all = 1; > + int need_check; > + > + if (rte_pci_bus.bus.conf.scan_mode == RTE_BUS_SCAN_WHITELIST) > + check_all = 0; > > FOREACH_DEVICE_ON_PCIBUS(dev) { > + devargs = dev->device.devargs; > + > + need_check = 0; > + if (check_all) Unless I'm mistaken, you will check blacklisted devices as well here. The condition should be something like: if (check_all && devargs == NULL) Which means that both ifs can be refactored as if ((check_all ^ (devargs != NULL)) == 0) continue; Removing need_check. But it can be hard to read. > + need_check = 1; > + else if (devargs != NULL && > + devargs->policy == RTE_DEV_WHITELISTED) > + need_check = 1; > + > + if (!need_check) > + continue; > + > if (dev->kdrv == RTE_KDRV_IGB_UIO || > dev->kdrv == RTE_KDRV_UIO_GENERIC) { > return 1; > -- > 2.7.4 > -- Gaëtan Rivet 6WIND