From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Subject: Re: [PATCH v1] mempool/octeontx: remove dead code from
	gpool2handle
Date: Sat, 21 Oct 2017 15:13:30 +0530
Message-ID: <20171021094329.GA14930@jerin>
References: <20171020153958.10236-1-santosh.shukla@caviumnetworks.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, thomas@monjalon.net
To: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-BN3-obe.outbound.protection.outlook.com
 (mail-bn3nam01on0049.outbound.protection.outlook.com [104.47.33.49])
 by dpdk.org (Postfix) with ESMTP id C2C761B2B9
 for <dev@dpdk.org>; Sat, 21 Oct 2017 11:43:56 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20171020153958.10236-1-santosh.shukla@caviumnetworks.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

-----Original Message-----
> Date: Fri, 20 Oct 2017 15:39:58 +0000
> From: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> To: dev@dpdk.org
> Cc: thomas@monjalon.net, jerin.jacob@caviumnetworks.com, Santosh Shukla
>  <santosh.shukla@caviumnetworks.com>
> Subject: [PATCH v1] mempool/octeontx: remove dead code from gpool2handle
> X-Mailer: git-send-email 2.13.0
> 
> Coverity Issue: 195000
> Fixes: 02fd6c744350 ("mempool/octeontx: support allocation")
> 
> Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

> ---
>  drivers/mempool/octeontx/octeontx_fpavf.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/mempool/octeontx/octeontx_fpavf.c b/drivers/mempool/octeontx/octeontx_fpavf.c
> index 6bdfc0339..cd36a195d 100644
> --- a/drivers/mempool/octeontx/octeontx_fpavf.c
> +++ b/drivers/mempool/octeontx/octeontx_fpavf.c
> @@ -176,9 +176,6 @@ octeontx_fpa_gpool2handle(uint16_t gpool)
>  	RTE_ASSERT(gpool < FPA_VF_MAX);
>  
>  	res = &fpadev.pool[gpool];
> -	if (unlikely(res == NULL))
> -		return 0;
> -
>  	return (uintptr_t)res->bar0 | gpool;
>  }
>  
> -- 
> 2.13.0
>