From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavan Nikhilesh Bhagavatula Subject: Re: [PATCH 1/3] evendev: fix inconsistency in event queue config Date: Mon, 23 Oct 2017 14:11:39 +0530 Message-ID: <20171023084138.GA27709@PBHAGAVATULA-LT> References: <1507814147-8223-1-git-send-email-pbhagavatula@caviumnetworks.com> <20171020103032.GA7404@PBHAGAVATULA-LT> <20171020190927.GA18722@PBHAGAVATULA-LT> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: "Van Haaren, Harry" , jerin.jacob@caviumnetworks.com Return-path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0048.outbound.protection.outlook.com [104.47.42.48]) by dpdk.org (Postfix) with ESMTP id 147BD1B310 for ; Mon, 23 Oct 2017 10:42:05 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 23, 2017 at 08:04:26AM +0000, Van Haaren, Harry wrote: > > From: Pavan Nikhilesh Bhagavatula [mailto:pbhagavatula@caviumnetworks.com] > > Sent: Friday, October 20, 2017 8:09 PM > > To: Van Haaren, Harry > > Cc: dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH 1/3] evendev: fix inconsistency in event > > queue config > > > > On Fri, Oct 20, 2017 at 04:38:57PM +0000, Van Haaren, Harry wrote: > > > > > > Sure, I see two sane-ish options: > > > > > > 1) Return an error code from get_attr(), which actually means "ALL TYPES". > > Feels a bit weird, because an error value is really a valid return. > > > > > > 2) Return UINT_MAX (aka, -1) as the scheduling value. Applications that > > use/care about the scheduling type must check, others can ignore it. > > > > > > I'm not sure which of these is the better/less-bad solution. Opinions? -H > > > > > > > I think 1st option would be good, we could use ENOTUNIQ to represent that > > the > > queue type is "ALL TYPE". > > > > Thoughts? > > > OK with me! > Hey Harry/Jerin, Sadly ENOTUNIQ is not supported on freebsd so, would returning EOPNOTSUPP make sense as it is closest error message that has similar meaning. I found ENOATTR in freebsd but that's not supported on linux. Thanks, Pavan