From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shijith Thotton Subject: Re: [PATCH] igb_uio: remove device reset in open Date: Mon, 23 Oct 2017 17:58:08 +0530 Message-ID: <20171023122807.GA17153@localhost.localdomain> References: <20171020165511.47899-1-ferruh.yigit@intel.com> <44560a31-d8dc-b2e1-1589-95020fb654f3@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jingjing Wu , Gregory Etelson , Harish Patil , Thomas Monjalon , dev@dpdk.org, stable@dpdk.org, Jianfeng Tan , George Prekas , Sergio Gonzalez Monroy To: Ferruh Yigit Return-path: Content-Disposition: inline In-Reply-To: <44560a31-d8dc-b2e1-1589-95020fb654f3@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 20, 2017 at 09:57:38AM -0700, Ferruh Yigit wrote: > On 10/20/2017 9:55 AM, Ferruh Yigit wrote: > > Remove device reset during application start, the reset for application > > exit still there. > > > > Reset in open removed because of following comments: > > 1- Device reset not completed when VF driver loaded, which cause VF PMD > > initialization error. > > Adding delay can solve the issue but will increase driver load time. > > > > 2- Reset will be issues all devices unconditionally, not very efficient > > way. > > > > Fixes: b58eedfc7dd5 ("igb_uio: issue FLR during open and release of device file") > > Cc: stable@dpdk.org > > > > Signed-off-by: Ferruh Yigit > > Hi Jingjing, Shijith, Gregory, Harish, > > Can you please test this on top of current master (which has already Jingjin's > fix) ? Hi Ferruh, Tested for LiquidIO cards and it works. Thanks, Shijith