From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bing Zhao Subject: [pktgen] [PATCH] Fix the protocol settings with the range command. Date: Tue, 24 Oct 2017 16:37:18 +0800 Message-ID: <20171024083718.22624-1-ilovethull@163.com> Cc: dev@dpdk.org, Bing Zhao , bing.zhao@hxt-semitech.com, jie2.liu@hxt-semitech.com, jia.he@hxt-semitech.com To: keith.wiles@intel.com Return-path: Received: from m50-135.163.com (m50-135.163.com [123.125.50.135]) by dpdk.org (Postfix) with ESMTP id A61E71B756 for ; Tue, 24 Oct 2017 10:37:22 +0200 (CEST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" A "%" is missing in the command line, so the parameter comparison always returns failure. And the local variable "what" points to the argv[4], it is incorrect for this command since the argc is 4 and the max should be argv[3]. Signed-off-by: bing.zhao@hxt-semitech.com Signed-off-by: jie2.liu@hxt-semitech.com Signed-off-by: jia.he@hxt-semitech.com --- app/cli-functions.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/cli-functions.c b/app/cli-functions.c index 076b86e..5e58f9c 100644 --- a/app/cli-functions.c +++ b/app/cli-functions.c @@ -150,7 +150,7 @@ static struct cli_map range_map[] = { { 31, "range %P src ip "SMMI" %4" }, { 32, "range %P dst ip %4 %4 %4 %4" }, { 33, "range %P src ip %4 %4 %4 %4" }, - { 40, "range %P proto tcp|udp" }, + { 40, "range %P proto %|tcp|udp" }, { 50, "range %P dst port "SMMI" %d" }, { 51, "range %P src port "SMMI" %d" }, { 52, "range %P dst port %d %d %d %d" }, @@ -280,7 +280,7 @@ range_cmd(int argc, char **argv) break; case 40: foreach_port(portlist, - range_set_proto(info, what) ); + range_set_proto(info, argv[3]) ); break; case 50: foreach_port(portlist, -- 2.11.0.windows.1