From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH] net/mlx4: fix targetless internal rule creation Date: Tue, 24 Oct 2017 11:21:17 +0200 Message-ID: <20171024092117.GY26782@6wind.com> References: <1508834730-30271-1-git-send-email-matan@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Matan Azrad Return-path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id EA0EE1B738 for ; Tue, 24 Oct 2017 11:21:29 +0200 (CEST) Received: by mail-wm0-f45.google.com with SMTP id u138so14323440wmu.5 for ; Tue, 24 Oct 2017 02:21:29 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1508834730-30271-1-git-send-email-matan@mellanox.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 24, 2017 at 08:45:30AM +0000, Matan Azrad wrote: > The corrupted code allowed to create internal rule with no any target queue > in case the rule creation ocured before queues creation. ocured => occurred > > For example, when user calls rte_eth_dev_default_mac_addr_set after probe > and before dev_configure, mlx4 failis because the RSS queue number was 0. failis => fails > > The fix prevents internal rules creation before queues creation based on > future creation before traffic start. > > Fixes: 7d8675956f57 ("net/mlx4: add RSS support outside flow API") Since adding MAC addresses before dev_configure() was not taken into account in the design of the affected function, I suggest appending: Fixes: bdcad2f4843a ("net/mlx4: refactor internal flow rules") > Signed-off-by: Matan Azrad Acked-by: Adrien Mazarguil Thanks. -- Adrien Mazarguil 6WIND