From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH 5/5] eal: use a single version map file
Date: Tue, 24 Oct 2017 10:48:03 +0100
Message-ID: <20171024094803.GA28136@bricha3-MOBL3.ger.corp.intel.com>
References: <20171019163629.28618-1-bruce.richardson@intel.com>
 <20171019163629.28618-6-bruce.richardson@intel.com>
 <1544893.XYOyShJzD1@xps>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 530F51B76E
 for <dev@dpdk.org>; Tue, 24 Oct 2017 11:48:07 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <1544893.XYOyShJzD1@xps>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Oct 24, 2017 at 01:21:39AM +0200, Thomas Monjalon wrote:
> 19/10/2017 18:36, Bruce Richardson:
> > Since the functions exported by DPDK EAL on all OS's should be
> > identical, we should not need separate function version files for each
> > OS. Therefore move existing version files to the top-level EAL
> > directory.
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> This small change is missing and added when applying:
> 
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -88,6 +88,7 @@ EAL API and common code
>  F: lib/librte_eal/common/*
>  F: lib/librte_eal/common/include/*
>  F: lib/librte_eal/common/include/generic/
> +F: lib/librte_eal/rte_eal_version.map
>  F: doc/guides/prog_guide/env_abstraction_layer.rst
>  F: test/test/test_alarm.c
>  F: test/test/test_atomic.c
> 

Thanks, good catch.